Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread Report 2nd time cont. #71

Merged
merged 67 commits into from
Sep 16, 2019

Conversation

ascherer
Copy link
Contributor

@ascherer ascherer commented Jul 13, 2019

“Factual Results” completed. About 80 pages more to proofread (plus the “quotes”).

Now that the major issues are fixed, the Report is almost pleasant to read.

@ascherer
Copy link
Contributor Author

Home at last! I've finished the first complete round through the whole Mueller Report. Time permitting, I'll start all over again.

ascherer added 7 commits July 21, 2019 16:10
Avoid clobbering the footnotes; wrapfigure overwrites them.
This fixes at least one horribly overful line in a footnote.
This may be ambiguous, but it typesets better.
@iandennismiller
Copy link
Owner

I am watching this pull request closely! It looks like it will be epic!

@ascherer
Copy link
Contributor Author

Done. Amazing how many types of errors needed addressing (including quite a few in the original Report).

Add some links to major section.
Gosh!  Just by scrolling through the PDF and looking at the footnotes,
I unearth another heap of typographic errors.
By '\protect'íng the fragile '\censor' macro, it can be used in
headings. The overfull TOC lines will be addressed later.
After the titlepage, we give a concise overview of the full Report by
listing the main sections only.

Each start page of the two Volumes and the Appendices has its own local
TOC with the same structure as the original Report.

For dead-tree reading, we sprinkle in a few 'clear double pages' to
start on right sides of spreads.
Align markers and heading texts vertically.
Give page numbers a tad more room.
@ascherer
Copy link
Contributor Author

Mayday! One of the recent commits broke the table of contents: The non-automatic chapter numbers are all set to '0'. Will bisect ASAP.

@iandennismiller
Copy link
Owner

No worries! I have not merged just yet.

Would it be okay if I reviewed this as soon as you push a fix for the table of contents?

@ascherer
Copy link
Contributor Author

ascherer commented Aug 14, 2019

Already found a solution: the 'chapter' counter has to be increased in 'main.tex' (or rather 'chapter-1.tex' etc. Will commit tomorrow.

(1) Fix the broken table of contents with updated labels and use of
    \hyperref instead of \hyperlink.
(2) Purge no less that 2,390 warnings about undefined 'Hfootnote'
    references.  These came from the fact that 'hyperref' was not
    loaded as the last package in 'include.tex'.
(3) After moving 'hyperref' to the end of 'include.tex', the
    TeX-compilation broke completely, because of '\verb+atim+' stuff
    in '\footnote{s}'. Fixing this required making the use of verbatim
    material in footnotes 'robust' by using '\SaveVerb/\UseVerb' from
    'fancyvrb'. This added file 'saveverb.tex' with verbatim labels.
@ascherer
Copy link
Contributor Author

I think I'll try to address issue #36 next: https://tex.stackexchange.com/questions/816/cyrillic-in-latex

Curiously enough, with the "kpfonts" main font and "computer modern
cyrillic" for the TS2 encoding, this brings the total number of pages in
the generated PDF file to exactly "448", just as in the original report.

The file sizes, however, are completely different:
-rw-rw-r-- 1 andreas andreas   5707679 Aug 16 02:39 main.pdf
-rw-rw-r-- 1 andreas andreas 145509756 Apr 21 19:12 mueller-report.pdf
@ascherer
Copy link
Contributor Author

ascherer commented Aug 16, 2019

@iandennismiller please review this massive heap of changes. I'll take this weekend off.

AFAICS, this PR fixes, or at least partly addresses, issues #30, #31, #33, #36, #37, #55, #65, and #69.

Copy link
Owner

@iandennismiller iandennismiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay. I am going to merge all these commits now!

@iandennismiller iandennismiller merged commit 3aa16a2 into iandennismiller:master Sep 16, 2019
@ascherer ascherer deleted the proofread-vol-2 branch September 16, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants