Switch to Farmer's Delight Refabricated #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ update dependencies Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
Signed-off-by: unilock <[email protected]>
|
Farmer's Delight Refabricated now has a compatibility layer for mods that depend on the old Farmer's Delight [Fabric], making this PR unnecessary (though probably still a good idea in the long run). It looks like they reimplemented WildPatchBlock slightly differently than I did? It might be worth borrowing their code for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the mod from the old Farmer's Delight [Fabric] to the new Farmer's Delight Refabricated, which is more true to the original mod and is generally better in most regards.
A decent amount of unnecessary / ambiguous code was also cleaned up.
Note that all instances of
WildPatchBlockwere replaced withWildCropBlock(source), which requires a Suspicious Stew status effect be specified. I've simply put in a placeholder value (Absorption for zero ticks); feel free to adjust it as you see fit.Closes #72.