Pair pytest with GitHub actions #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, As you said, the tests are (unfortunately) old and most-likely are using functions from the old API. That said, the current lot of tests is quite underwhelming and barely does a thing. I have been thinking about at least adding one test to ensure that a new update didn't break any functionality (see #17 ). For now I will leave the PR open and accept after I write some tests that actually test something :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you see fit, it would be useful to automatically test each push to the main branch through something like actions/checkout. This PR adds the action config file and runs pytest on each push to
main.I tried to run pytest locally, but I got some errors that led me to think that some pytests are perhaps too dated. I hope such integration is still relevant for your case.