fix: mfa infinite loop (#77)

* fix: mfa infinite loop * Removes unused component parameter --------- Co-authored-by: Juliano <[email protected]>
iaurg · Oct 4, 2023 · ca809e4 · ca809e4
1 parent 61dde7e
commit ca809e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/frontend/src/components/MFAModal/MFACode.tsx b/frontend/src/components/MFAModal/MFACode.tsx
@@ -11,16 +11,16 @@ type MFACodeProps = {
 
 export default function MFACode({ handleStep }: MFACodeProps) {
   const [code, setCode] = useState(["", "", "", "", "", ""]);
-  const { user } = useContext(AuthContext);
+  const { user,setUser } = useContext(AuthContext);
 
   const handleSubmit = async () => {
     // Handle submission logic here
-    console.log("Submitted code:", code.join(""));
     const endpoint = user.mfaEnabled ? "/auth/2fa/disable" : "/auth/2fa/enable";
     await api
       .post(endpoint, { code: code.join("") }, { withCredentials: true })
       .then((r) => {
         if (r.status == 201) handleStep(2);
+        setUser({ ...user, mfaEnabled: !user.mfaEnabled });
       })
       .catch((e) => {
         toast.error("Código inválido", {
@@ -29,6 +29,7 @@ export default function MFACode({ handleStep }: MFACodeProps) {
         console.log(e);
       });
   };
+
   const baseURL = process.env.NEXT_PUBLIC_API_URL;
 
   return (

diff --git a/frontend/src/components/MFAModal/MFASuccess.tsx b/frontend/src/components/MFAModal/MFASuccess.tsx
@@ -1,14 +1,10 @@
 import { AuthContext } from "@/contexts/AuthContext";
 import { useContext } from "react";
 
-type MFASuccessProps = {
-  handleStep: (step: number) => void;
-};
 
-export default function MFASuccess({ handleStep }: MFASuccessProps) {
-  const { user, setUser } = useContext(AuthContext);
-  // TODO solve infinite loop
-  setUser({ ...user, mfaEnabled: !user.mfaEnabled });
+export default function MFASuccess() {
+  const { user } = useContext(AuthContext);
+
   return (
     <>
       <div className="mt-2">

diff --git a/frontend/src/components/MFAModal/index.tsx b/frontend/src/components/MFAModal/index.tsx
@@ -74,7 +74,7 @@ export default function MFAModal() {
                   ) : step === 1 ? (
                     <MFACode handleStep={handleStep} />
                   ) : step === 2 ? (
-                    <MFASuccess handleStep={handleStep} />
+                    <MFASuccess />
                   ) : null}
                 </Dialog.Panel>
               </Transition.Child>