Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement chat DMs between friends #128

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Feature: Implement chat DMs between friends #128

merged 6 commits into from
Nov 27, 2023

Conversation

vcwild
Copy link
Collaborator

@vcwild vcwild commented Nov 26, 2023

Description

  • Implements DMs in the UI
  • Remove Chat module finished TODOs
  • Add some alt text to components
  • Private chats don't show in the main chat lobby anymore
  • Only private chats created by the user are temporarily displayed in the chat lobby
  • All chat DMs are database persistent
  • If a user resets its chat component, all of the DM chat are removed from the displayed list, but still persisted in the database.
  • DM chats have a nice icon.

Related Issue

Closes #121

Mentions #127

- Remove finished todos
- Add some alt text to components
- Private chats don't show in the main chat lobby anymore
- Only private chats created by the user are temporarily displayed in the chat lobby
- If a user resets its chat component, all of the DM chats are removed
- All chat DMs are database persisted
Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
42-transcendence ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 11:38am

Copy link
Owner

@iaurg iaurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@vcwild vcwild merged commit 8149ec7 into main Nov 27, 2023
4 checks passed
@vcwild vcwild deleted the feat/create-dm branch November 27, 2023 22:13
iaurg added a commit that referenced this pull request Nov 30, 2023
* feat: implement chat DMs between friends

- Remove finished todos
- Add some alt text to components
- Private chats don't show in the main chat lobby anymore
- Only private chats created by the user are temporarily displayed in the chat lobby
- If a user resets its chat component, all of the DM chats are removed
- All chat DMs are database persisted

* lint: remove unused imports

* fix: filter private chat to no appear on list chats

* style: resize name and hide users popover on dm

* style: fixed chat width

* style: add cursor pointer into dm icon

---------

Co-authored-by: Italo A <[email protected]>
vcwild added a commit that referenced this pull request Dec 5, 2023
* feat: activate loggers on game

* feat: component to invite user to a game

* feat: game invite prototype

* ref: inviteError event name change

* Feature: Implement chat DMs between friends (#128)

* feat: implement chat DMs between friends

- Remove finished todos
- Add some alt text to components
- Private chats don't show in the main chat lobby anymore
- Only private chats created by the user are temporarily displayed in the chat lobby
- If a user resets its chat component, all of the DM chats are removed
- All chat DMs are database persisted

* lint: remove unused imports

* fix: filter private chat to no appear on list chats

* style: resize name and hide users popover on dm

* style: fixed chat width

* style: add cursor pointer into dm icon

---------

Co-authored-by: Italo A <[email protected]>

* feat/127-add-alt (#132)

* feat: add action hover tip on each button

* fix: use a single alt attribute

---------

Co-authored-by: Victor Wildner <[email protected]>

* Fix/125-chat-reload (#133)

* style: cards justify

* fix: chat reloading when access history page

* feat/game-actions (#134)

* feat: better game actions and titles

* feat: show player name on play screen

* feat: unmute user automatically after 5s (#136)

* feat/owner-chat-actions (#135)

* feat: allow owner update and remove password from chat

* fix: wrong html tree

* feat: update chat listing on render list

* feat: on chat open goes to the bottom

* refactor: remove console log

* feat: update lock icon

* fix: avoid read undefined

* fix: missing provider and duplicated toaster

---------

Co-authored-by: Victor Wildner <[email protected]>

* Feat/profile popover (#138)

* refactor: remove not user isFriend property

* feat: add buttons and remove bio description

---------

Co-authored-by: Victor Wildner <[email protected]>

* Feat/descriptive top buttons (#139)

* feat: add missing back home button

* feat: more descriptive menu actions

* Fixes 2fa (#130)

* Splits auth-only updates from user update service
- Removes mfaEnabled from user field interceptor
- Removes mfaEnabled from PatchUserDto
- Removes secrets from the frontend user model

* fix: Removes duplicate Toaster
- chore: cleanup in user dto

* Fixes CORS on 2fa code submission
- Fixes redirect not pushing to auth/2fa

* Feat/front block user (#144)

* feat: add block button

* feat: replicate button pattern

* fix: avatar wrong initial letter

* feat: implement block user (#148)

* Fix: Cleaning abandoned lobby rooms (#142)

* feat: activate loggers on game

* feat: component to invite user to a game

* feat: make game a global context

* refactor: game invite to game

* style: lint file

* feat: implement invite player to game

* fix: returning game copy instead game reference

* ref: cleaning invite lobby in disconnect

* fix:game invite

* feat: modal to handle invite actions

* refactor: remove not used imports

* feat: add guestRejected emit socket

* refactor: update match history create to update with login

* refactor: remove not used player user id

* feat: add invite rejected actions and alerts

* fix: inviting offline player

* ref: class attributes

* feat: stopGame event handler

* fix: event call stopGame on gameFinished handler

* feat: modal in game not show

* fix: breaking line names

* refactor: remove not used template

* style: responsive elements

* fix: client not leaving socket room

* fix: abandoned game still running

* feat: player that abandone game looses

* ref: removing useless code

* ref: removing useless code

---------

Co-authored-by: Guilherme Martinelli <[email protected]>
Co-authored-by: Victor Wildner <[email protected]>
Co-authored-by: Juliano Choi <[email protected]>
Co-authored-by: Guilherme Ferreira Martinelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DMs
2 participants