-
Notifications
You must be signed in to change notification settings - Fork 8
Helpermessage and respective changes to helper #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rewrite
Are you sure you want to change the base?
Conversation
…eflect those changes in helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, Indiance! I can see a few changes to make here:
- Although channel-role relations are to be read from
config.toml
, we should store the helper message IDs usingdb
. See other cogs for examples on how to use this - namely, we should be editing thedb
on helpermessage creation and deletion specifically. - Currently the description is hard-coded, but ideally this is also to be read from
config.toml
. - The
embed_getter
method appears buggy - I have suggested some changes, particularly writing it as a generator so you can account for all the relevant helpermessages in a loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! Please see comments for specific changes/questions.
In terms of other comments:
- General consistency - adding periods to the end of docstrings and messages sent to discord channels would be great.
- Adding logger statements for helpermessage create, delete, and description editing would help with debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run Ruff once on this branch—many strings include single quotes when they should all have double quotes.
I'm also not sure how changing the HelperMessage
model will involve things like migrations—Nath probably knows better.
For now, this looks good. My nitpicks are only grammatical, such as amendments in docstrings and error messages.
.gitignore
Outdated
@@ -130,4 +130,5 @@ dmypy.json | |||
|
|||
config.json | |||
config.toml | |||
bot/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this folder for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally shouldn't be there since its a folder to my venv. changing it
This reverts commit 013c154. reverting
Followed @ilikecubesnstuff 's guidelines on the creation of helpermessage which includes: