Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7037: Added check if user has permission to change password #1047

Merged
merged 3 commits into from
Jan 4, 2024
Merged

IBX-7037: Added check if user has permission to change password #1047

merged 3 commits into from
Jan 4, 2024

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets IBX-7037
Bug fix? no
New feature? yes/no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Dec 11, 2023
@mateuszdebinski mateuszdebinski requested a review from a team December 11, 2023 15:23
@mateuszdebinski mateuszdebinski self-assigned this Dec 11, 2023
@mateuszdebinski mateuszdebinski mentioned this pull request Dec 11, 2023
Merged
2 tasks
@mateuszdebinski mateuszdebinski force-pushed the IBX-7037_user_without_permission_can_open_form_password branch 3 times, most recently from 741e617 to d638792 Compare December 11, 2023 15:44
@mateuszdebinski
Copy link
Contributor Author

Failed test because missing code from ibexa/user#64

dew326
dew326 requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behat fails probably related to the PR changes.

This was referenced Dec 12, 2023
Closed
Closed
Closed
@mateuszdebinski
Copy link
Contributor Author

Regression test passed

@mateuszdebinski mateuszdebinski force-pushed the IBX-7037_user_without_permission_can_open_form_password branch from dee9c47 to 5dc67a1 Compare December 29, 2023 12:21
@mateuszdebinski mateuszdebinski force-pushed the IBX-7037_user_without_permission_can_open_form_password branch from 5dc67a1 to eb0191d Compare December 29, 2023 12:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 8e02192 into main Jan 4, 2024
19 of 22 checks passed
@dew326 dew326 deleted the IBX-7037_user_without_permission_can_open_form_password branch January 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mateuszdebinski @adamwojs @dew326 @barbaragr @mikadamczyk @Nattfarinn @ciastektk @ViniTou