Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7492: Fixed error when editing image in user profile #1108

Open
wants to merge 2 commits into
base: 4.6
Choose a base branch
from
Open

IBX-7492: Fixed error when editing image in user profile #1108

wants to merge 2 commits into from

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Jan 9, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7492
Depends on ibexa/content-forms#60
https://github.com/ibexa/image-editor/pull/88
Type bug
Target version v4.6
BC breaks no
Doc needed no

Currently ezimage and ezimageasset editing forms view depends on contentId and versionNo route params, which are not available in user profile edit view.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
100.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs mentioned this pull request Jan 9, 2024
Open
5 tasks
@mikadamczyk
Copy link
Contributor

@adamwojs The base branch should be fixed here

@adamwojs adamwojs changed the base branch from main to 4.6 July 22, 2024 08:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
100.0% Duplication on New Code

See analysis details on SonarCloud

@juskora
Copy link
Contributor

juskora commented Aug 1, 2024 •
edited
Loading

Error occurs for user Editor content type, under Editors Role.
2024-08-01_13-52-14
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@dew326 dew326 dew326 approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@adamwojs @mikadamczyk @juskora @Steveb-p @dew326 @ViniTou @konradoboza @Nattfarinn @ciastektk