IBX-9262: Fixed Relation::Asset not being cleaned up on content deletion #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Apr 9, 2025
ciastektk
approved these changes
Apr 9, 2025
konradoboza
reviewed
Apr 9, 2025
tests/integration/Core/Repository/ContentService/ImageAssetTest.php
Outdated
Show resolved
Hide resolved
wiewiurdp
approved these changes
Apr 9, 2025
mikadamczyk
approved these changes
Apr 9, 2025
Comment on lines
+1230
to
+1231
| * id: int|string, | ||
| * version: int|string, |
There was a problem hiding this comment.
Are there any situations in which these values are integers?
There was a problem hiding this comment.
Yes, it strictly depends on database driver.
konradoboza
approved these changes
Apr 9, 2025
Steveb-p
approved these changes
Apr 9, 2025
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
|
|
||
| $assetContent = $this->contentService->loadContentByContentInfo($assetContent->getContentInfo()); | ||
|
|
||
| /** @var \Ibexa\Core\FieldType\ImageAsset\Value $value */ |
There was a problem hiding this comment.
You can make an assertion instead.
tbialcz
approved these changes
Apr 9, 2025
Co-authored-by: Paweł Niedzielski <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We were missing image asset cleanup when asset content was deleted.
For QA:
Check also if that change did not affect normal relation field type cleanup in any way.
Documentation: