Skip to content

Upgrade phpDocumentor #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 4.6
Choose a base branch
from
Open

Upgrade phpDocumentor #2808

wants to merge 4 commits into from

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Jul 2, 2025 •
edited
Loading

Question Answer
JIRA Ticket
Versions 4.6, 5.0
Edition

Upgrade phpDocumentor from 3.7.1 to 3.8.0

It unduplicates properties that are redeclared with @property tag family.

Example with Ibexa\Contracts\Core\Limitation\Target\Version:

Note: I would have prefer to see the "public read-only" declaration kept instead of the "protected" one.
But, on Ibexa's side, instead of the old solution based on a protected property + a magic getter + a tag to document it, PHP 8.1 has a better solution: public readonly array $allLanguageCodesList = [];

Ignoring whitespaces, those are the modified entries:

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025

Preview of modified files: no change to preview.

@adriendupuis adriendupuis marked this pull request as ready for review July 2, 2025 13:47
mnocon
mnocon approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriendupuis @mnocon