Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7298: Comment in .platform/services.yaml referes to non-existent file #67

Merged
merged 2 commits into from
Dec 6, 2023
Merged

IBX-7298: Comment in .platform/services.yaml referes to non-existent file #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd8c88
IBX-7298: Comment in .platform/services.yaml referes to non-existent …
vidarl Dec 5, 2023
aeabd15
fixup! IBX-7298: Comment in .platform/services.yaml referes to non-ex…
vidarl Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/platformsh/common/3.3.x-dev/.platform/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ rediscache:
# type: elasticsearch:7.7
# disk: 512

# Due to logic in app/config/env/platformsh.php, do not change the service name to something different than 'varnish'
# Due to logic in vendor/ezsystems/ezplatform-core/src/EzPlatformCoreBundle/bundle/DependencyInjection/EzPlatformCoreExtension.php, do not change the service name to something different from 'varnish'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use FQCN instead of file path ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Fixed in aeabd15

varnish:
type: 'varnish:6.0'
relationships:
Expand Down
2 changes: 1 addition & 1 deletion resources/platformsh/common/3.3/.platform/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ rediscache:
# type: elasticsearch:7.7
# disk: 512

# Due to logic in app/config/env/platformsh.php, do not change the service name to something different than 'varnish'
# Due to logic in vendor/ezsystems/ezplatform-core/src/EzPlatformCoreBundle/bundle/DependencyInjection/EzPlatformCoreExtension.php, do not change the service name to something different from 'varnish'
varnish:
type: 'varnish:6.0'
relationships:
Expand Down
2 changes: 1 addition & 1 deletion resources/platformsh/ibexa-commerce/3.3.x-dev/.platform/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ solrsearch:
# type: elasticsearch:7.7
# disk: 512

# Due to logic in app/config/env/platformsh.php, do not change the service name to something different than 'varnish'
# Due to logic in vendor/ezsystems/ezplatform-core/src/EzPlatformCoreBundle/bundle/DependencyInjection/EzPlatformCoreExtension.php, do not change the service name to something different from 'varnish'
varnish:
type: 'varnish:6.0'
relationships:
Expand Down
2 changes: 1 addition & 1 deletion resources/platformsh/ibexa-commerce/3.3/.platform/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ solrsearch:
# type: elasticsearch:7.7
# disk: 512

# Due to logic in app/config/env/platformsh.php, do not change the service name to something different than 'varnish'
# Due to logic in vendor/ezsystems/ezplatform-core/src/EzPlatformCoreBundle/bundle/DependencyInjection/EzPlatformCoreExtension.php, do not change the service name to something different from 'varnish'
varnish:
type: 'varnish:6.0'
relationships:
Expand Down
Loading