-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7818: Fixed direct acces to index.php with long URL #70
Conversation
@glye Could you please take a look on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OLTC-fperrin Ye gods, it looks like you're right! Considering that it is non-security, target branch should be v4.6. Technically v3.3 is maintained until Sunday, but we're unlikely to get this past QA by then.
@OLTC-fperrin Correction, it seems we'll get another v3.3 release out, so please set target branch to v3.3. |
Hello @glye,
Not entirely sure how I do that, I don't see a 3.3 branch in the list. |
My mistake. @webhdx Is the 1.0 branch here used for v3.3, or is that a different repo? |
@glye that's correct. '1.0' branch is used for Ibexa DXP 3.3 version. |
Thanks. So @OLTC-fperrin please set the target branch to 1.0. Thanks! |
@glye , ok, it's done from github, but i'm not sure that was the correct way (130 commits ??), should I rebase my commit on the branch 1.0 ? anyway, if it's easier, feel free to just close this PR and add the fix to the branch you want properly. |
Rebase, yes please. |
@glye ok, i'm thoroughly confused, the template files don't exist on branch 1.0. Not sure what you want me to do. |
Yes let's keep it for |
@OLTC-fperrin can you rebase your PR against |
…st-install into IBX-7818-fix-index-issue
Ok I rebased and changed the target branch of the PR, I hope I did that correctly 🤞 |
Many thanks, looks good to me! |
@OLTC-fperrin thank you for your contribution! I passed this PR to our QA team on your behalf to be tested. Once we have confirmation all works correctly, we will merge it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved
Regression: ibexa/commerce#1065
@OLTC-fperrin thank you. |
v4.6
Fixed an issue when index.php can be accessed directly if the URL is long and complexe enough
Checklist:
Ran PHP CS Fixer for new PHP code (use$ composer fix-cs
). (N/A)@ibexa/engineering can you review this PR ? thank you