Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #80

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

alongosz
Copy link
Member

🎫 Issue IBX-8138

Description:

Applied rules from Symfony 5 Rector set lists.

For QA:

No QA needed. Regression tests should be enough.

Documentation:

This is code refactoring without behavior change. No documentation changes needed.

@@ -104,7 +104,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$output->writeln("\nPlatform.sh config files installed successfully");
}

return 0;
return \Symfony\Component\Console\Command\Command::SUCCESS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing import here 😉

Applied rules:
 * CommandConstantReturnCodeRector
@alongosz alongosz force-pushed the ibx-8138-symfony-5-rule-sets branch from 8518476 to ceb2455 Compare August 6, 2024 13:06
@adamwojs adamwojs merged commit bbf5268 into main Aug 9, 2024
8 checks passed
@adamwojs adamwojs deleted the ibx-8138-symfony-5-rule-sets branch August 9, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants