Removed Acholi dialect from the list of available translations #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
adamwojs
approved these changes
Aug 5, 2023
konradoboza
approved these changes
Aug 7, 2023
|
@mikadamczyk Can we move this PR to QA ? |
mikadamczyk
force-pushed
the
remove_acholi_from_translation_list
branch
from
b3b11a0
to
f9a8958
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since In-context translations are toggled by a dedicated setting there is no need to have Acholi dialect on the list of available translations. This change will also prevent validation errors because Acholi is not a valid Locale
Checklist:
$ composer fix-cs)