Add route short names to stop deletion warning #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
changed the title
daniel-heppner-ibigroup
approved these changes
Sep 21, 2023
binh-dam-ibigroup
requested changes
Sep 22, 2023
lib/common/actions/index.js
Outdated
| @@ -183,7 +183,7 @@ const PatternLinkErrorMessage = (props) => { | |||
| return ( | |||
| <li style={{listStyle: 'none', margin: '3px 0px'}}> | |||
| <a href={patternPath}> | |||
| {`Route ${pattern.routeId}, Pattern ${pattern.patternId}`} | |||
| {`Route ${pattern.routeShortName}, Pattern ${pattern.patternId}`} | |||
There was a problem hiding this comment.
This is not working with a number of feeds I previously imported. For these feeds, the route short name is undefined. You should fall back on route ID IMO.
There was a problem hiding this comment.
I agree, good call. I have added route ID as a fall back in bfcde9e
5 tasks
binh-dam-ibigroup
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Companion PR to conveyal/gtfs-lib#396 to make use of route short names in deletion error messages