Prevent WAL locking by resetting prepared statements after use #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should possibly fix unlimited WAL growing (like in ibireme#115) Cached prepared statements in _dbPrepareStmt are not reset until next call, so both automatic and manual checkpoints are failing to occur, causing WAL to grow and never to be merged into main DB file (see http://sqlite.1065341.n5.nabble.com/sqlite3-wal-checkpoint-v2-returning-SQLITE-LOCKED-in-what-circumstances-td86662.html)
lukapool
reviewed
Dec 11, 2019
| @@ -429,11 +442,13 @@ - (NSData *)_dbGetValueWithKey:(NSString *)key { | |||
| const void *inline_data = sqlite3_column_blob(stmt, 0); | |||
| int inline_data_bytes = sqlite3_column_bytes(stmt, 0); | |||
| if (!inline_data || inline_data_bytes <= 0) return nil; | |||
| sqlite3_reset(stmt); | |||
There was a problem hiding this comment.
sqlite3_reset(stmt); should add before line:444 if (!inline_data || inline_data_bytes <= 0) return nil;
wbcyclist
added a commit
to wbcyclist/YYCache
that referenced
this pull request
May 21, 2020
Merge pull request ibireme#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should possibly fix unlimited WAL growing (like in #115)
Cached prepared statements in _dbPrepareStmt are not reset until next call, so both automatic and manual checkpoints are failing to occur,
causing WAL to grow and never to be merged into main DB file (see http://sqlite.1065341.n5.nabble.com/sqlite3-wal-checkpoint-v2-returning-SQLITE-LOCKED-in-what-circumstances-td86662.html)