fix(flink): fix strip

ibis/backends/sql/compilers/flink.py

@@ -110,7 +110,6 @@ class FlinkCompiler(SQLGlotCompiler):
         ops.StringLength: "char_length",
         ops.StringToDate: "to_date",
         ops.StringToTimestamp: "to_timestamp",
-        ops.Strip: "trim",
         ops.TypeOf: "typeof",
     }
 
@@ -589,5 +588,10 @@ def visit_ArrayCollect(self, op, *, arg, where, order_by, include_null):
             out = sge.Filter(this=out, expression=sge.Where(this=where))
         return out
 
+    def visit_Strip(self, op, *, arg):
+        # TODO: at some point, the upstream `BTRIM` function should work, but it
+        # currently doesn't, so we use a combination of left and right trim here
+        return self.visit_RStrip(op, arg=self.visit_LStrip(op, arg=arg))
+
 
 compiler = FlinkCompiler()

ibis/backends/tests/test_string.py

@@ -1297,17 +1297,6 @@ def string_temp_table(backend, con):
             lambda t: t.string_col.strip(),
             lambda t: t.str.strip(),
             id="strip",
-            marks=[
-                pytest.mark.notimpl(
-                    ["flink"],
-                    raises=AssertionError,
-                    reason="""
-                    Flink TRIM doesn't respect strip characters
-                    but rstrip and lstrip work.
-                    There's `BTRIM` but maybe only in dev?
-                    """,
-                ),
-            ],
         ),
         param(
             lambda t: t.string_col.upper(),