Skip to content

Commit

Permalink
chore(signature): swap order of arguments to compatible
Browse files Browse the repository at this point in the history
Should be `implementation, interface_def`, not the other way around
  • Loading branch information
gforsyth committed Jun 13, 2024
1 parent a6d0c18 commit 26ea616
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ibis/backends/tests/test_signatures.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ def test_signatures(base_cls, method, backend_cls):
base_sig = inspect.signature(getattr(base_cls, method))
backend_sig = inspect.signature(getattr(backend_cls, method))

assert compatible(base_sig, backend_sig, check_annotations=False)
# Usage is compatible(implementation_signature, defined_interface_signature, ...)
assert compatible(backend_sig, base_sig, check_annotations=False)

0 comments on commit 26ea616

Please sign in to comment.