chore: avoid setting environment variables except for local cases

ibis-project · Dec 31, 2024 · 2c55209 · 2c55209
1 parent 66b3ed2
commit 2c55209
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.env b/.env
@@ -6,3 +6,5 @@ MYSQL_PWD="ibis"
 MSSQL_SA_PASSWORD="1bis_Testing!"
 DRUID_URL="druid://localhost:8082/druid/v2/sql"
 SPARK_CONFIG=./docker/spark-connect/conf.properties
+AWS_PROFILE="ibis-testing"
+AWS_REGION="us-east-2"
diff --git a/flake.nix b/flake.nix
@@ -143,7 +143,6 @@
           inherit shellHook;
 
           PYSPARK_PYTHON = "${env}/bin/python";
-          AWS_PROFILE = "ibis-testing";
 
           # needed for mssql+pyodbc
           ODBCSYSINI = pkgs.writeTextDir "odbcinst.ini" ''

diff --git a/ibis/backends/athena/tests/conftest.py b/ibis/backends/athena/tests/conftest.py
@@ -20,12 +20,12 @@
 
 
 IBIS_ATHENA_S3_STAGING_DIR = env.get("IBIS_ATHENA_S3_STAGING_DIR", "s3://ibis-testing/")
-IBIS_ATHENA_REGION_NAME = env.get("IBIS_ATHENA_REGION_NAME", "us-east-2")
-IBIS_ATHENA_PROFILE_NAME = env.get("IBIS_ATHENA_PROFILE_NAME", "ibis-testing")
+AWS_REGION = env.get("AWS_REGION", "us-east-2")
+AWS_PROFILE = env.get("AWS_PROFILE")
 CONNECT_ARGS = dict(
     s3_staging_dir=IBIS_ATHENA_S3_STAGING_DIR,
-    region_name=IBIS_ATHENA_REGION_NAME,
-    profile_name=IBIS_ATHENA_PROFILE_NAME,
+    region_name=AWS_REGION,
+    profile_name=AWS_PROFILE,
 )