Skip to content

Commit

Permalink
refactor(flink, exasol): require keyword args for do_connect
Browse files Browse the repository at this point in the history
BREAKING CHANGE: All arguments to `do_connect` are now keyword-only.
  • Loading branch information
gforsyth committed Jun 14, 2024
1 parent 5f3cef2 commit 461e770
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions ibis/backends/exasol/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def version(self) -> str:

def do_connect(
self,
*,
user: str,
password: str,
host: str = "localhost",
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/flink/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def dialect(self):
# TODO: remove when ported to sqlglot
return self.compiler.dialect

def do_connect(self, table_env: TableEnvironment) -> None:
def do_connect(self, *, table_env: TableEnvironment) -> None:

Check warning on line 54 in ibis/backends/flink/__init__.py

View check run for this annotation

Codecov / codecov/patch

ibis/backends/flink/__init__.py#L54

Added line #L54 was not covered by tests
"""Create a Flink `Backend` for use with Ibis.
Parameters
Expand Down

0 comments on commit 461e770

Please sign in to comment.