Skip to content

Commit

Permalink
fix: original kwargs are not passed to the backend._from_url() if…
Browse files Browse the repository at this point in the history
… `scheme != "file"`
  • Loading branch information
nextchamp-saqib authored Sep 3, 2024
1 parent 7a6af8d commit 6b3e179
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions ibis/backends/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1396,11 +1396,12 @@ def connect(resource: Path | str, **kwargs: Any) -> BaseBackend:
if len(value) == 1:
kwargs[name] = value[0]

# Merge explicit kwargs with query string, explicit kwargs
# taking precedence
kwargs.update(orig_kwargs)

if scheme == "file":
path = parsed.netloc + parsed.path
# Merge explicit kwargs with query string, explicit kwargs
# taking precedence
kwargs.update(orig_kwargs)
if path.endswith(".duckdb"):
return ibis.duckdb.connect(path, **kwargs)
elif path.endswith((".sqlite", ".db")):
Expand Down

0 comments on commit 6b3e179

Please sign in to comment.