chore(deps): update gvenzl/oracle-free docker tag to v23.4 (#9120)

ibis-project · May 5, 2024 · 829e0fd · 829e0fd
1 parent d8119fb
commit 829e0fd
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 33 deletions.
diff --git a/compose.yaml b/compose.yaml
@@ -341,7 +341,7 @@ services:
       - druid
 
   oracle:
-    image: gvenzl/oracle-free:23.3-slim
+    image: gvenzl/oracle-free:23.4-slim
     environment:
       ORACLE_PASSWORD: ibis
       ORACLE_DATABASE: IBIS_TESTING

diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -302,11 +302,6 @@ def mean_and_std(v):
                     raises=AttributeError,
                     reason="'IntegerColumn' object has no attribute 'notany'",
                 ),
-                pytest.mark.broken(
-                    ["oracle"],
-                    raises=OracleDatabaseError,
-                    reason="ORA-02000: missing AS keyword",
-                ),
                 pytest.mark.notimpl(["exasol"], raises=ExaQueryError),
             ],
         ),
@@ -320,11 +315,6 @@ def mean_and_std(v):
                     raises=AttributeError,
                     reason="'IntegerColumn' object has no attribute 'any'",
                 ),
-                pytest.mark.broken(
-                    ["oracle"],
-                    raises=OracleDatabaseError,
-                    reason="ORA-02000: missing AS keyword",
-                ),
                 pytest.mark.notimpl(["exasol"], raises=ExaQueryError),
             ],
         ),
@@ -350,11 +340,6 @@ def mean_and_std(v):
                     raises=AttributeError,
                     reason="'IntegerColumn' object has no attribute 'notall'",
                 ),
-                pytest.mark.broken(
-                    ["oracle"],
-                    raises=OracleDatabaseError,
-                    reason="ORA-02000: missing AS keyword",
-                ),
                 pytest.mark.notimpl(["exasol"], raises=ExaQueryError),
             ],
         ),
@@ -368,11 +353,6 @@ def mean_and_std(v):
                     raises=AttributeError,
                     reason="'IntegerColumn' object has no attribute 'all'",
                 ),
-                pytest.mark.broken(
-                    ["oracle"],
-                    raises=OracleDatabaseError,
-                    reason="ORA-02000: missing AS keyword",
-                ),
                 pytest.mark.notimpl(["exasol"], raises=ExaQueryError),
             ],
         ),

diff --git a/ibis/backends/tests/test_client.py b/ibis/backends/tests/test_client.py
@@ -1367,10 +1367,6 @@ def test_persist_expression_repeated_cache(alltypes):
     raises=com.UnsupportedOperationError,
     reason="Feature is not yet implemented: CREATE TEMPORARY TABLE",
 )
-@mark.notimpl(
-    ["oracle"],
-    reason="Oracle error message for a missing table/view doesn't include the name of the table",
-)
 def test_persist_expression_release(con, alltypes):
     non_cached_table = alltypes.mutate(
         test_column=ibis.literal("calculation"), other_column=ibis.literal("big calc 3")

diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py
@@ -2032,7 +2032,7 @@ def test_select_scalar(alltypes):
     assert (res.y == 1).all()
 
 
-@pytest.mark.broken(["mssql", "oracle"], reason="incorrect syntax")
+@pytest.mark.broken(["mssql"], reason="incorrect syntax")
 def test_isnull_equality(con, backend, monkeypatch):
     monkeypatch.setattr(ibis.options, "default_backend", con)
     t = ibis.memtable({"x": ["a", "b", None], "y": ["c", None, None], "z": [1, 2, 3]})

diff --git a/ibis/backends/tests/test_window.py b/ibis/backends/tests/test_window.py
@@ -17,7 +17,6 @@
     GoogleBadRequest,
     ImpalaHiveServer2Error,
     MySQLOperationalError,
-    OracleDatabaseError,
     PsycoPg2InternalError,
     Py4JJavaError,
     PyDruidProgrammingError,
@@ -249,9 +248,6 @@ def calc_zscore(s):
                 .astype(bool)
             ),
             id="cumnotany",
-            marks=[
-                pytest.mark.broken(["oracle"], raises=OracleDatabaseError),
-            ],
         ),
         param(
             lambda t, win: (t.double_col == 0).all().over(win),
@@ -272,9 +268,6 @@ def calc_zscore(s):
                 .astype(bool)
             ),
             id="cumnotall",
-            marks=[
-                pytest.mark.broken(["oracle"], raises=OracleDatabaseError),
-            ],
         ),
         param(
             lambda t, win: t.double_col.sum().over(win),