Skip to content

Commit

Permalink
test(markers): remove dask markers
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Aug 17, 2024
1 parent c172f87 commit 885a4eb
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
6 changes: 1 addition & 5 deletions ibis/backends/tests/test_aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1357,8 +1357,7 @@ def test_group_concat_ordered(alltypes, df, filtered):
raises=com.OperationNotDefinedError,
)
@pytest.mark.notimpl(
["clickhouse", "dask", "pandas", "pyspark", "flink"],
raises=com.UnsupportedOperationError,
["clickhouse", "pandas", "pyspark", "flink"], raises=com.UnsupportedOperationError
)
@pytest.mark.parametrize(
"filtered",
Expand Down Expand Up @@ -1395,9 +1394,6 @@ def test_collect_ordered(alltypes, df, filtered):
["druid", "exasol", "impala", "mssql", "mysql", "oracle", "sqlite"],
raises=com.OperationNotDefinedError,
)
@pytest.mark.notimpl(
["dask"], raises=AttributeError, reason="Dask doesn't implement tolist()"
)
@pytest.mark.parametrize(
"filtered",
[
Expand Down
4 changes: 1 addition & 3 deletions ibis/backends/tests/test_dot_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@
pd = pytest.importorskip("pandas")
tm = pytest.importorskip("pandas.testing")

dot_sql_never = pytest.mark.never(
["dask", "pandas"], reason="dask and pandas do not accept SQL"
)
dot_sql_never = pytest.mark.never(["pandas"], reason="pandas does not accept SQL")

_NAMES = {
"bigquery": f"ibis_gbq_testing_{getpass.getuser()}_{PYTHON_SHORT_VERSION}.functional_alltypes",
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/tests/test_generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ def test_filter(backend, alltypes, sorted_df, predicate_fn, expected_fn):
raises=PyDruidProgrammingError,
reason="requires enabling window functions",
)
@pytest.mark.notimpl(["polars", "dask", "pandas"], raises=com.OperationNotDefinedError)
@pytest.mark.notimpl(["polars", "pandas"], raises=com.OperationNotDefinedError)
@pytest.mark.notyet(
["oracle"],
raises=OracleDatabaseError,
Expand Down
4 changes: 2 additions & 2 deletions ibis/backends/tests/test_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def query(t, group_cols):

@pytest.mark.parametrize("backend_name", _get_backends_to_test())
@pytest.mark.notimpl(
["dask", "pandas", "polars"], raises=ValueError, reason="not a SQL backend"
["pandas", "polars"], raises=ValueError, reason="not a SQL backend"
)
def test_mixed_qualified_and_unqualified_predicates(backend_name, snapshot):
t = ibis.table({"x": "int64"}, name="t")
Expand All @@ -229,7 +229,7 @@ def test_mixed_qualified_and_unqualified_predicates(backend_name, snapshot):

@pytest.mark.parametrize("backend_name", _get_backends_to_test())
@pytest.mark.notimpl(
["dask", "pandas", "polars"], raises=ValueError, reason="not a SQL backend"
["pandas", "polars"], raises=ValueError, reason="not a SQL backend"
)
def test_rewrite_context(snapshot, backend_name):
table = ibis.memtable({"test": [1, 2, 3, 4, 5]}, name="test")
Expand Down

0 comments on commit 885a4eb

Please sign in to comment.