chore(bigquery): fix groupconcat impl

ibis-project · Aug 2, 2024 · a30996c · a30996c
1 parent c482aa2
commit a30996c
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/ibis/backends/sql/compilers/bigquery.py b/ibis/backends/sql/compilers/bigquery.py
@@ -175,6 +175,15 @@ def visit_TimestampDelta(self, op, *, left, right, part):
             "timestamp difference with mixed timezone/timezoneless values is not implemented"
         )
 
+    def visit_GroupConcat(self, op, *, arg, sep, where, order_by):
+        if where is not None:
+            arg = self.if_(where, arg, NULL)
+
+        if order_by:
+            sep = sge.Order(this=sep, expressions=order_by)
+
+        return sge.GroupConcat(this=arg, separator=sep)
+
     def visit_FloorDivide(self, op, *, left, right):
         return self.cast(self.f.floor(self.f.ieee_divide(left, right)), op.dtype)