Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(risingwave): bump to latest risingwave release and enable now-passing tests #10001

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 3, 2024

I noticed we had a very old version of RisingWave, and bumped it to the latest release, which fixed a number of bugs and added support for RANGE window function frames, which caused a number of tests to start XPASS-ing.

@cpcloud cpcloud added this to the 9.4 milestone Sep 3, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests ci Continuous Integration issues or PRs risingwave The RisingWave backend labels Sep 3, 2024
@cpcloud cpcloud requested review from jcrist and gforsyth September 3, 2024 11:21
Copy link
Contributor

github-actions bot commented Sep 3, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title bump risingwave test(risingwave): bump to latest risingwave release and enable now-passing tests Sep 3, 2024
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcrist
Copy link
Member

jcrist commented Sep 3, 2024

Side question - why does the bot upgrade some images but not others? I noticed risingwave had an old image the other day (debugging the distinct fusion PR), but thought that may have been intentional since the bot usually bumps them.

@cpcloud cpcloud enabled auto-merge (squash) September 3, 2024 11:38
@cpcloud cpcloud merged commit a89b689 into ibis-project:main Sep 3, 2024
81 checks passed
@cpcloud cpcloud deleted the bump-risingwave branch September 3, 2024 12:11
@cpcloud
Copy link
Member Author

cpcloud commented Sep 3, 2024

I think it might be because their image is stored on ghcr, and not dockerhub.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 3, 2024

Actually, I think it's because the version string "nightly-$date" wasn't something that renovate knows how to upgrade.

@jcrist
Copy link
Member

jcrist commented Sep 3, 2024

Makes sense, I guess we'll find out next time they cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs risingwave The RisingWave backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants