Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency jupyterlite-core to >=0.4,<0.5 [security] #10046

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 6, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jupyterlite-core >=0.3,<0.4 -> >=0.4,<0.5 age adoption passing confidence

GitHub Vulnerability Alerts

GHSA-gj55-2xf9-67rq

Impact

The vulnerability depends on user interaction by opening a malicious notebook with Markdown cells, or Markdown file using JupyterLab preview feature.

A malicious user can access any data accessible from JupyterLite and perform arbitrary actions in JupyterLite environment.

Patches

JupyterLite 0.4.1 was patched.

Workarounds

There is no workaround for the underlying DOM Clobbering susceptibility. However, select plugins can be disabled on deployments which cannot update in a timely fashion to minimise the risk. These are:

  • @jupyterlab/mathjax-extension:plugin - users will loose ability to preview mathematical equations
  • @jupyterlab/markdownviewer-extension:plugin - users will loose ability to open Markdown previews
  • @jupyterlab/mathjax2-extension:plugin (if installed with optional jupyterlab-mathjax2 package) - an older version of the mathjax plugin for JupyterLab 4.x

To disable these extensions populate the disabledExtensions key in jupyter-config-data stanza of jupyter-lite.json as documented on https://jupyterlite.readthedocs.io/en/stable/howto/configure/config_files.html#jupyter-lite-json

{
  "jupyter-lite-schema-version": 0,
  "jupyter-config-data": {
    "appName": "My JupyterLite App",
    "disabledExtensions": [
      "@&#8203;jupyterlab/markdownviewer-extension:plugin",
      "@&#8203;jupyterlab/mathjax-extension:plugin",
      "@&#8203;jupyterlab/mathjax2-extension:plugin"
    ]
  }
}

To confirm that the plugins were disabled manual inspection of the built page is required.

References

Upstream advisory: GHSA-9q39-rmj3-p4r2

Notes

This change has a potential to break rendering of some markdown. There is a setting in Sanitizer which allows to revert to the previous sanitizer settings (allowNamedProperties).


Release Notes

jupyterlite/jupyterlite (jupyterlite-core)

v0.4.1

Compare Source

(Full Changelog)

Maintenance and upkeep improvements
Documentation improvements
Contributors to this release

(GitHub contributors page for this release)

@​github-actions | @​jtpio | @​michaelweinold | @​zonca

v0.4.0

Compare Source

(Full Changelog)

Enhancements made
Bugs fixed
Maintenance and upkeep improvements
Documentation improvements
API and Breaking Changes
Contributors to this release

(GitHub contributors page for this release)

@​afshin | @​bollwyvl | @​Carreau | @​dependabot | @​github-actions | @​jtpio | @​juntyr | @​krassowski | @​martinRenou


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Issues or PRs related to dependencies docs Documentation related issues or PRs labels Sep 6, 2024
Copy link
Contributor Author

renovate bot commented Sep 6, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: poetry.lock
Updating dependencies
Resolving dependencies...

Creating virtualenv ibis-framework-3Icqsljt-py3.12 in /home/ubuntu/.cache/pypoetry/virtualenvs

Because no versions of jupyterlite-pyodide-kernel match >0.3,<0.3.1 || >0.3.1,<0.3.2 || >0.3.2,<0.4
 and jupyterlite-pyodide-kernel (0.3.0) depends on jupyterlite-core (>=0.3.0,<0.4.0), jupyterlite-pyodide-kernel (>=0.3,<0.3.1 || >0.3.1,<0.3.2 || >0.3.2,<0.4) requires jupyterlite-core (>=0.3.0,<0.4.0).
And because jupyterlite-pyodide-kernel (0.3.1) depends on jupyterlite-core (>=0.3.0,<0.4.0)
 and jupyterlite-pyodide-kernel (0.3.2) depends on jupyterlite-core (>=0.3.0,<0.4.0), jupyterlite-pyodide-kernel (>=0.3,<0.4) requires jupyterlite-core (>=0.3.0,<0.4.0).
So, because ibis-framework depends on both jupyterlite-core (>=0.4,<0.5) and jupyterlite-pyodide-kernel (>=0.3,<0.4), version solving failed.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud
Copy link
Member

cpcloud commented Sep 7, 2024

Closing in favor of #10052.

@cpcloud cpcloud closed this Sep 7, 2024
@cpcloud cpcloud deleted the renovate/pypi-jupyterlite-core-vulnerability branch September 7, 2024 12:20
Copy link
Contributor Author

renovate bot commented Sep 7, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (>=0.4,<0.5). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant