refactor(backends): split memtable existence check out #10053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
cpcloud
commented
Sep 7, 2024
| @@ -33,7 +33,6 @@ class Backend(SQLBackend): | |||
| name = "druid" | |||
| compiler = sc.druid.compiler | |||
| supports_create_or_replace = False | |||
| supports_in_memory_tables = True | |||
There was a problem hiding this comment.
The default value of this flag is True, hence the removal in a few places.
cpcloud
commented
Sep 7, 2024
| @@ -253,50 +253,47 @@ def _register_in_memory_table(self, op: ops.InMemoryTable) -> None: | |||
| f"got null typed columns: {null_columns}" | |||
| ) | |||
|
|
|||
| # only register if we haven't already done so | |||
| if (name := op.name) not in self.list_tables(): | |||
There was a problem hiding this comment.
The only bits I changed here were to remove this conditional, and then dedent what was previously indented inside the branch.
cpcloud
changed the title
cpcloud
force-pushed
the
factor-out-memtable-existence-check
branch
2 times, most recently
from
63fe2b9 to
31372ea
Compare
cpcloud
changed the title
cpcloud
force-pushed
the
factor-out-memtable-existence-check
branch
from
31372ea to
33bdc39
Compare
cpcloud
added
sql
|
I'll split out the perf improvements to a separate PR. |
cpcloud
force-pushed
the
factor-out-memtable-existence-check
branch
2 times, most recently
from
d05de5e to
1b5dbb4
Compare
cpcloud
commented
Sep 9, 2024
jcrist
approved these changes
Sep 9, 2024
cpcloud
force-pushed
the
factor-out-memtable-existence-check
branch
2 times, most recently
from
c342081 to
9935cb9
Compare
…mization over time
cpcloud
force-pushed
the
factor-out-memtable-existence-check
branch
from
e3341ae to
1fa978c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of
twoa few PRs to implement #10044. This one factors out memtable existence checks to allow a generic implementation of register-only-if-not-exists, as well as to allow improvement over time of this check as we discover faster existence check implementations.