Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backends): clean up resources produced by
memtable
#10055refactor(backends): clean up resources produced by
memtable
#10055Changes from 6 commits
4bec625
f119e20
85ac3ad
ff12db6
22cec69
a0d43b5
a287865
39dbe02
7bcd327
191a107
b19cc51
06ae2e4
dd2ee70
b1aab14
26acf61
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1128 in ibis/backends/__init__.py
Codecov / codecov/patch
ibis/backends/__init__.py#L1128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed these variable names because
table = <not the memtable>
causes it to get GC'd. I gave another example of this in the PR description.