Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency sqlglot to >=23.4,<25.22 #10109

Merged
merged 7 commits into from
Sep 15, 2024
Merged

fix(deps): update dependency sqlglot to >=23.4,<25.22 #10109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1308de4
test(clickhouse): check type string rather than specific type structure
cpcloud Sep 15, 2024
5c097cf
chore(deps): bump sqlglot and relock
cpcloud Sep 15, 2024
9edc734
chore(deps): do not let sqlglot transform datafusion uuid function
cpcloud Sep 15, 2024
13420be
fix(clickhouse): move nullable computation into attribute to match sq…
cpcloud Sep 15, 2024
246e1ba
test: ensure that tables are dropped in `test_create_table_in_memory`
cpcloud Sep 15, 2024
1f45c14
chore: thread `nullable` to decimal method
cpcloud Sep 15, 2024
e22c9f0
chore(bigquery): regen snapshots
cpcloud Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions ibis/backends/clickhouse/tests/test_datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import hypothesis.strategies as st
import pytest
import sqlglot as sg
import sqlglot.expressions as sge
from packaging.version import parse as vparse
from pytest import param

Expand Down Expand Up @@ -311,16 +310,5 @@ def test_type_roundtrip(ibis_type):


def test_arrays_nullable():
# if dtype.nullable and not (dtype.is_map() or dtype.is_array()):
sge_type = ClickHouseType.from_ibis(dt.Array("float"))
typecode = sge.DataType.Type

assert sge_type == sge.DataType(
this=typecode.ARRAY,
expressions=[
sge.DataType(
this=typecode.NULLABLE, expressions=[sge.DataType(this=typecode.DOUBLE)]
)
],
nested=True,
)
assert sge_type.sql("clickhouse") == "Array(Nullable(Float64))"
3 changes: 3 additions & 0 deletions ibis/backends/sql/compilers/datafusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,5 +505,8 @@ def visit_GroupConcat(self, op, *, arg, sep, where, order_by):
def visit_ArrayFlatten(self, op, *, arg):
return self.if_(arg.is_(NULL), NULL, self.f.flatten(arg))

def visit_RandomUUID(self, op, **kw):
return self.f.anon.uuid()


compiler = DataFusionCompiler()
Loading