-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): support python 3.13 #10582
Conversation
f602b10
to
0efac8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@@ -53,6 +53,11 @@ let | |||
# Use base package set from pyproject.nix builders | |||
(pkgs.callPackage pyproject-nix.build.packages { | |||
inherit python; | |||
stdenv = pkgs.stdenv.override { | |||
targetPlatform = pkgs.stdenv.targetPlatform // { | |||
darwinSdkVersion = "12.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly required for python 3.13 support, but it sure does make life easier by allowing more wheels to be used on macOS. A bunch of the more-complex-to-build wheels like scipy and scikit-learn are only available using a 12.0 darwin SDK build.
The remaining single failure was fixed in kylebarron/arro3#276 and once the 0.4.5 wheels are uploaded (after this CI run succeeds), then I'll update |
Ok, bumped those deps by way of |
I'll do some follow up work to see whether we can run any of the clouds with 3.13. |
Add support Python 3.13