Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): support python 3.13 #10582

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Dec 16, 2024

Add support Python 3.13

@cpcloud cpcloud added this to the 10.0 milestone Dec 16, 2024
@github-actions github-actions bot added ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix labels Dec 16, 2024
@cpcloud cpcloud force-pushed the python313 branch 3 times, most recently from f602b10 to 0efac8f Compare December 16, 2024 15:11
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

.github/workflows/nix.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added bigquery The BigQuery backend sql Backends that generate SQL labels Dec 16, 2024
@@ -53,6 +53,11 @@ let
# Use base package set from pyproject.nix builders
(pkgs.callPackage pyproject-nix.build.packages {
inherit python;
stdenv = pkgs.stdenv.override {
targetPlatform = pkgs.stdenv.targetPlatform // {
darwinSdkVersion = "12.0";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly required for python 3.13 support, but it sure does make life easier by allowing more wheels to be used on macOS. A bunch of the more-complex-to-build wheels like scipy and scikit-learn are only available using a 12.0 darwin SDK build.

@cpcloud
Copy link
Member Author

cpcloud commented Dec 16, 2024

The remaining single failure was fixed in kylebarron/arro3#276 and once the 0.4.5 wheels are uploaded (after this CI run succeeds), then I'll update uv.lock using just update and we should be good to merge this PR.

@cpcloud
Copy link
Member Author

cpcloud commented Dec 16, 2024

Ok, bumped those deps by way of just update.

@cpcloud cpcloud enabled auto-merge (squash) December 16, 2024 17:06
@cpcloud
Copy link
Member Author

cpcloud commented Dec 16, 2024

I'll do some follow up work to see whether we can run any of the clouds with 3.13.

@cpcloud cpcloud merged commit 35f2b9d into ibis-project:main Dec 16, 2024
81 checks passed
@cpcloud cpcloud deleted the python313 branch December 16, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix sql Backends that generate SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants