feat(dtypes): allow passing nullable kwarg to string parsed dtypes
#10632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
|
Seems more like a new feature, but no big deal if you want to keep it as a bugfix. |
gforsyth
changed the title
nullable kwarg to string parsed dtypesnullable kwarg to string parsed dtypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Noted in #10243, passing
nullabletoibis.dtypewhen using a string name forthe dtype leads to an unhelpful error. Instead, we should just support this.
This adds support for 'primitive' dtype specifications -- there's no defined
behavior for how to specify nested nullable types with a single keyword
argument, but this should cover most cases.
Issues closed
xref #10243 but doesn't close it