Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-deps): use unified lock file format for conda lock files #7390

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 18, 2023

This PR fixes our conda-lock setup and installation instructions to use the unified conda lock file format, which reduces the number of files in the repo and allows us to remove platform specific installation instructions. The remaining major issue is the incorrect resolution of the seaborn-split package.

One nice benefit of using the unified lock file format is that we can use pypi packages without having to upstream them to conda-forge first.

@cpcloud cpcloud added this to the 7.1 milestone Oct 18, 2023
@cpcloud cpcloud added ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development labels Oct 18, 2023
@cpcloud cpcloud force-pushed the redo-conda-lock branch 3 times, most recently from b914895 to f6f849e Compare October 18, 2023 09:36
@cpcloud cpcloud changed the title redo conda lock chore(dev-deps): use unified lock file format for conda lock files Oct 18, 2023
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! those are some big ol' lock files you've got there.

@@ -56,7 +56,7 @@ repos:
rev: v4.5.0
hooks:
- id: check-added-large-files
args: ["--maxkb=700"]
args: ["--maxkb=710"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The megalockfiles are right at 705 😬

@gforsyth gforsyth merged commit 310d92b into ibis-project:master Oct 18, 2023
@cpcloud cpcloud deleted the redo-conda-lock branch October 18, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants