refactor: remove show_sql in favor of print(to_sql)
#7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Nov 3, 2023
cpcloud
force-pushed
the
8.x.x
branch
4 times, most recently
from
2f8bc62 to
af8b6a3
Compare
cpcloud
added
the
breaking change
cpcloud
force-pushed
the
remove-show-sql
branch
2 times, most recently
from
6c9ca87 to
6670dbc
Compare
BREAKING CHANGE: replace `ibis.show_sql(expr)` calls with `print(ibis.to_sql(expr))` or if using Jupyter or IPython `ibis.to_sql(expr)`
cpcloud
force-pushed
the
remove-show-sql
branch
from
6670dbc to
09d3203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we syntax highlight the result of
to_sqlin IPython and Jupyter, we can decrease API surface a bit by removingshow_sqlin favor ofprint(to_sql(...))for folks that are not using IPython or Jupyter.