Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix failing generic expression docstrings #7788

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Dec 16, 2023

Fix ibis.param, Value.name and ibis.table APIs example docstrings, all of which were failing to render.

I'm not entirely sure why these are failing given the add_ibis fixture's behavior, which should disable interactive mode before every doctest.

Closes #7787.

@cpcloud cpcloud added this to the 7.2 milestone Dec 16, 2023
@cpcloud cpcloud added bug Incorrect behavior inside of ibis docs Documentation related issues or PRs labels Dec 16, 2023
@cpcloud
Copy link
Member Author

cpcloud commented Dec 16, 2023

Ah, the add_ibis fixture isn't running when rendering docstrings using quarto!

@cpcloud cpcloud force-pushed the fix-param-docstring-example branch 3 times, most recently from 75025a2 to 58d9b62 Compare December 16, 2023 16:53
@cpcloud cpcloud force-pushed the fix-param-docstring-example branch from 58d9b62 to 94b489c Compare December 17, 2023 09:35
@cpcloud cpcloud merged commit 168f3e8 into ibis-project:master Dec 17, 2023
90 checks passed
@cpcloud cpcloud deleted the fix-param-docstring-example branch December 17, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: https://ibis-project.org/reference/expression-generic#examples-36
1 participant