Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Improve SLS flow for various configurations #1619

Merged
merged 10 commits into from
Jan 30, 2025
Merged

[minor] Improve SLS flow for various configurations #1619

merged 10 commits into from
Jan 30, 2025

Conversation

rawa-resul
Copy link
Contributor

@rawa-resul rawa-resul commented Jan 12, 2025

Description

  • Removed 13. Generate SLSCfg tasks from ibm/mas_devops/roles/sls/tasks/install/main.yml
  • Set sls_action to either ["install", "uninstall"] because these are the only roles we have
  • Set sls_action for the tasks/gencfg/main.yml role to either ["install", "gencfg"]
    • We want this role to run either after an install of SLS or just by itself if all we need to do is to generate the SlsCfg
  • Improved ibm/mas_devops/roles/sls/tasks/gencfg/main.yml role
    • We have clear tasks for when we use it on a fresh install, existing instance or external SLS

Testing

  • All of the above have been tested via the CLI

@rawa-resul rawa-resul changed the title [minor] Add support for various SLS configurations [minor] Improve SLS flow for various configurations Jan 23, 2025
@rawa-resul rawa-resul changed the title [minor] Improve SLS flow for various configurations [patch] Improve SLS flow for various configurations Jan 27, 2025
@rawa-resul rawa-resul changed the title [patch] Improve SLS flow for various configurations [minor] Improve SLS flow for various configurations Jan 27, 2025
@rawa-resul rawa-resul marked this pull request as ready for review January 27, 2025 13:52
@whitfiea whitfiea added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit 3dd8d99 Jan 30, 2025
2 checks passed
@whitfiea whitfiea deleted the sls-rr branch January 30, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants