Improve ACF install error reporting #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the authRc variable was shadowed in the ACF install path so it was not set to any meaningful value. This improves the error code produced by the ACF install path. The main observation is that multiple public keys are attempted and all but one of them will fail with CeLoginRc::RcBase::SignatureNotValid. That is a valid error code, but errors from keys where the signature was valid should take precedence. For example, consider when the second key is valid but the ACF is expired: the SignatureNotValid from the third key should not mask this more significant error code. Tested: Yes Scenarios: valid ACF installed, incorrect signature, expired ACF. The caller writes the error code into a journal entry. Signed-off-by: Joseph Reynolds <[email protected]>
|
This should be backported at least to FW1060. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the authRc variable was shadowed in the ACF install path so it was not set to any meaningful value.
This improves the error code produced by the ACF install path. The main observation is that multiple public keys are attempted and all but one of them will fail with CeLoginRc::RcBase::SignatureNotValid. That is a valid error code, but errors from keys where the signature was valid should take precedence. For example, consider when the second key is valid but the ACF is expired: the SignatureNotValid from the third key should not mask this more significant error code.
Tested: Yes
Scenarios: valid ACF installed, incorrect signature, expired ACF. The caller writes the error code into a journal entry.