Add support for ReadyToRemove interface #186
Open
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jeaaustx
reviewed
Sep 8, 2025
| @@ -0,0 +1,9 @@ | |||
| description: > | |||
| An indication of whether the inventory is prepared by the system for | |||
There was a problem hiding this comment.
nit: Seems like more common term would be "inventory item".
| @@ -0,0 +1,9 @@ | |||
| description: > | |||
| An indication of whether the inventory is prepared by the system for | |||
There was a problem hiding this comment.
nit: Interface description seems like it is usually termed as "Implement to..."
(this description reads more like the actual property description).
| - name: ReadyToRemove | ||
| type: boolean | ||
| description: > | ||
| An indication of whether the item is prepared by the system for |
There was a problem hiding this comment.
Question: Is this readonly? If not, then I'm wondering about this description. If the property is set to false versus set to true by something?
(The description as written seems to be about what a query of this property would indicate.)
|
add to approvelist |
This new D-Bus interface is implemented to indicate whether the inventory item is prepared by the system for removal. Signed-off-by: Abiola Asojo <[email protected]>
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
5145d4e to
00ebe9e
Compare
jeaaustx
approved these changes
Sep 11, 2025
|
Let's give this a week or two upstream before we take it downstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ReadyToRemove interface.