Dns resolution binding #271

ujjwal-ibm · 2023-06-07T05:31:12Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMISVirtualEndpointGateway_AllowDnsResolutionBinding
--- PASS: TestAccIBMISVirtualEndpointGateway_AllowDnsResolutionBinding (127.11s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     129.230s

=== RUN   TestAccIBMISVirtualEndpointGatewayDataSource_AllowDnsResolutionBinding
--- PASS: TestAccIBMISVirtualEndpointGatewayDataSource_AllowDnsResolutionBinding (110.66s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     112.854s

=== RUN   TestAccIBMISVirtualEndpointGatewaysDataSource_AllowDnsResolutionBinding
--- PASS: TestAccIBMISVirtualEndpointGatewaysDataSource_AllowDnsResolutionBinding (104.28s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     106.417s

=== RUN   TestAccIBMIsVPCDnsResolutionBindingResourceBasic
--- PASS: TestAccIBMIsVPCDnsResolutionBindingResourceBasic (72.63s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     74.793s

=== RUN   TestAccIBMIsVPCDnsResolutionBindingsDataSourceBasic
--- PASS: TestAccIBMIsVPCDnsResolutionBindingsDataSourceBasic (69.61s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     71.873s

=== RUN   TestAccIBMIsVPCDnsResolutionBindingDataSourceBasic
--- PASS: TestAccIBMIsVPCDnsResolutionBindingDataSourceBasic (73.08s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     75.238s

astha-jain · 2023-09-08T19:35:56Z

ibm/service/vpc/resource_ibm_is_vpc_test.go

+		default_security_group_name = "dsgn"
+		default_routing_table_name = "drtn"
+		tags = ["Tag1", "tag2"]
+	}`, name)


This configuration does not include DNS attributes?

astha-jain · 2023-09-14T15:39:38Z

examples/ibm-is-ng/main.tf

+	vpc {
+		id = ibm_is_vpc.vpc2.id
+	}
+}


missing examples for VPC

astha-jain · 2023-09-19T14:30:58Z

website/docs/r/is_vpc.html.markdown

@@ -53,6 +71,39 @@ Review the argument references that you can specify for your resource.
 - `default_network_acl_name` - (Optional, String) Enter the name of the default network access control list (ACL).
 - `default_security_group_name` - (Optional, String) Enter the name of the default security group.
 - `default_routing_table_name` - (Optional, String) Enter the name of the default routing table.
+- `dns` - (Optional, List) The DNS configuration for this VPC.
+
+  Nested scheme for `dns`:


Note - This feature is a Select Location availability invitation only feature. If used in other regions may lead to inconsistencies in state management.

astha-jain · 2023-09-19T14:31:10Z

website/docs/r/is_vpc_dns_resolution_binding.html.markdown

+subcategory: "Virtual Private Cloud API"
+---
+
+# ibm_is_vpc_dns_resolution_binding


Note - This feature is a Select Location availability invitation only feature. If used in other regions may lead to inconsistencies in state management.

astha-jain · 2023-09-19T14:31:16Z

website/docs/r/is_virtual_endpoint_gateway.html.markdown

@@ -88,6 +88,7 @@ Review the argument references that you can specify for your resource.
  **&#x2022;** For more information, about creating access tags, see [working with tags](https://cloud.ibm.com/docs/account?topic=account-tag&interface=ui#create-access-console).</br>
  **&#x2022;** You must have the access listed in the [Granting users access to tag resources](https://cloud.ibm.com/docs/account?topic=account-access) for `access_tags`</br>
  **&#x2022;** `access_tags` must be in the format `key:value`.
+- `allow_dns_resolution_binding` - (Optional, bool) Indicates whether to allow this endpoint gateway to participate in DNS resolution bindings with a VPC that has dns.enable_hub set to true.


Note - This feature is a Select Location availability invitation only feature. If used in other regions may lead to inconsistencies in state management.

astha-jain · 2023-09-21T18:13:53Z

website/docs/r/is_vpc.html.markdown

+		}
+	}
+}
+


Can we add an example with zone affinity please all three zones?

ujjwal-ibm · 2023-09-22T10:29:31Z

moving to upstream

astha-jain reviewed Sep 8, 2023

View reviewed changes

astha-jain reviewed Sep 14, 2023

View reviewed changes

examples/ibm-is-ng/main.tf

vpc {

id = ibm_is_vpc.vpc2.id

}

}

Copy link

Collaborator

astha-jain Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing examples for VPC

astha-jain reviewed Sep 19, 2023

View reviewed changes

astha-jain reviewed Sep 21, 2023

View reviewed changes

website/docs/r/is_vpc.html.markdown

}

}

}

Copy link

Collaborator

astha-jain Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an example with zone affinity please all three zones?

support for vpc dns resolution binding

bc14e2b

ujjwal-ibm force-pushed the dns-resolution-binding branch from 65bca04 to bc14e2b Compare September 22, 2023 10:29

ujjwal-ibm closed this Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dns resolution binding #271

Dns resolution binding #271

ujjwal-ibm commented Jun 7, 2023 •

edited

Loading

astha-jain Sep 8, 2023

astha-jain Sep 14, 2023

astha-jain Sep 19, 2023

astha-jain Sep 19, 2023

ujjwal-ibm Sep 20, 2023

astha-jain Sep 19, 2023

ujjwal-ibm Sep 20, 2023

astha-jain Sep 21, 2023

ujjwal-ibm commented Sep 22, 2023

Dns resolution binding #271

Dns resolution binding #271

Conversation

ujjwal-ibm commented Jun 7, 2023 • edited Loading

Community Note

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ujjwal-ibm commented Sep 22, 2023

ujjwal-ibm commented Jun 7, 2023 •

edited

Loading