Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature(Share-CRR): Cross region replication support for file share #292

Closed
wants to merge 18 commits into from
Closed

Feature(Share-CRR): Cross region replication support for file share #292

wants to merge 18 commits into from

Conversation

deepaksibm
Copy link
Collaborator

No description provided.

@deepaksibm
Copy link
Collaborator Author 

$ tfpt TestAccIbmIsShareCrossRegionReplication
=== RUN   TestAccIbmIsShareCrossRegionReplication
--- PASS: TestAccIbmIsShareCrossRegionReplication (89.05s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc	90.196s

SunithaGudisagarIBM1
SunithaGudisagarIBM1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my small comments here.
Post the incorporation PR is ready with code review

website/docs/d/is_share.html.markdown Outdated Show resolved Hide resolved
ibm/acctest/acctest.go Show resolved Hide resolved
@SunithaGudisagarIBM1
Copy link
Collaborator

May be we can try to change/update the encryption_key, source_share_crn and initial_owner and attach the results in jira

@deepaksibm
Copy link
Collaborator Author

upstream merged

@deepaksibm deepaksibm closed this Feb 21, 2024
@deepaksibm deepaksibm deleted the share-crr branch February 21, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 SunithaGudisagarIBM1 approved these changes

Assignees
No one assigned
Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepaksibm @SunithaGudisagarIBM1