Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC ID Filter is added when Subnet Name is specified in Datasource #299

Closed
wants to merge 1 commit into from

Conversation

SunithaGudisagarIBM1
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes IBM-Cloud#4872

Output from acceptance testing:

resource "ibm_is_vpc" "testacc_vpc" {
	name = "sunitha-vpc"
}

resource "ibm_is_subnet" "testacc_subnet" {
	name = "sunitha-subnet"
	vpc = "${ibm_is_vpc.testacc_vpc.id}"
	zone = "us-south-1"
	total_ipv4_address_count = 16
}
data "ibm_is_subnet" "ds_subnet" {
	identifier = "${ibm_is_subnet.testacc_subnet.id}"
}

data "ibm_is_subnet" "ds_subnet_name" {
  depends_on = [ ibm_is_subnet.testacc_subnet ]
	name =   "sunitha-subnet"
}

data "ibm_is_subnet" "ds_subnet_vpcid_subentname" {
  depends_on = [ ibm_is_subnet.testacc_subnet ]
  name =   "sunitha-subnet"
  vpc =  "${ibm_is_vpc.testacc_vpc.id}"
}
Screenshot 2023-10-24 at 9 14 37 PM Screenshot 2023-10-24 at 9 15 02 PM

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 changed the title VPC ID Filter is added when Subnet Name is specified VPC ID Filter is added when Subnet Name is specified in Datasource Oct 24, 2023
Copy link
Collaborator

@sreekarbvibm sreekarbvibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

Verified in us-south region

@sumitkumartiwari
Copy link
Collaborator

Please resolve the comments and create an upstream PR and add it here..

@SunithaGudisagarIBM1
Copy link
Collaborator Author

	data "ibm_is_subnets" "ds_subnets_resource_group" {
		/* depends_on = [ibm_is_subnet.testacc_subnet] */
		/* vpc = ibm_is_vpc.testacc_vpc.id */
    vpc_name = "tfp-vpc"
    		/* resource_group = "11caaa983d9c4beb82690daab08717e9" */

	}
Screenshot 2023-10-30 at 12 01 31 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

IBM-Cloud#4892

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 deleted the bugfix-is-subnet branch November 19, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibm_is_subnet returns the incorrect subnet ID
3 participants