Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(routine-table): added support for crn in routing table #374

Closed
wants to merge 10 commits into from

Conversation

SunithaGudisagarIBM1
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@SunithaGudisagarIBM1
Copy link
Collaborator Author

	data "ibm_is_vpc_routing_tables" "test1" {
		vpc =  ibm_is_vpc.testacc_vpc.id
	}
Screenshot 2024-08-04 at 5 21 50 PM
resource "ibm_is_vpc_routing_table" "test_route_rt" {
  vpc                           = ibm_is_vpc.testacc_vpc.id
  name                          = "test-vpc-routing-table"
  route_direct_link_ingress     = true
  route_transit_gateway_ingress = false
  route_vpc_zone_ingress        = false
}
Screenshot 2024-08-04 at 5 22 54 PM
data "ibm_is_vpc_routing_table" "ibm_is_vpc_routing_table_name" {
  vpc  = ibm_is_vpc.testacc_vpc.id
  name = ibm_is_vpc_routing_table.test_route_rt.name
}
Screenshot 2024-08-04 at 5 23 18 PM
data "ibm_is_vpc_default_routing_table" "def_route_table" {
  vpc = ibm_is_vpc.testacc_vpc.id
}
Screenshot 2024-08-04 at 5 24 27 PM
data "ibm_is_subnets" "ds_subnets_resource_group" {
}
Screenshot 2024-08-04 at 5 25 05 PM
data "ibm_is_subnet" "ds_subnet" {
  identifier = "0716-f3c6cdb5-7923-461f-826b-f1b4f1189970"
}
Screenshot 2024-08-04 at 5 25 41 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

resource "ibm_is_subnet" "testacc_subnet" {
  name            = "terrraform-test"
  vpc             = ibm_is_vpc.testacc_vpc.id
  zone            = "us-south-1"
  ipv4_cidr_block = "10.240.0.0/24"
 -> routing_table = ibm_is_vpc.testacc_vpc.default_routing_table
 -> routing_table_crn = ibm_is_vpc.testacc_vpc.default_routing_table_crn
  routing_table_crn = ibm_is_vpc_routing_table.test_route_rt.crn
  -> routing_table = ibm_is_vpc_routing_table.test_route_rt.routing_table
}
Screenshot 2024-08-04 at 6 44 38 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

resource "ibm_is_vpc_routing_table" "test_route_rt" {
  vpc                           = ibm_is_vpc.testacc_vpc.id
  name                          = "test-vpc-routing-table"
  route_direct_link_ingress     = false
  route_transit_gateway_ingress = false
  route_vpc_zone_ingress        = false
}
Screenshot 2024-08-04 at 6 45 17 PM

@deepaksibm deepaksibm changed the title enhancement(snapshot): added support for crn in routing table enhancement(routine-table): added support for crn in routing table Aug 7, 2024
@astha-jain
Copy link
Collaborator

Missing resource_group - ?

Copy link
Collaborator

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SunithaGudisagarIBM1
Copy link
Collaborator Author

Prod Testing Results

resource "ibm_is_vpc" "testacc_vpc" {
  name = "terraform-test-1"
}

data "ibm_is_vpc_default_routing_table" "def_route_table" {
  vpc = ibm_is_vpc.testacc_vpc.id
}
Screenshot 2024-08-28 at 11 23 19 PM Screenshot 2024-08-28 at 11 23 38 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

	data "ibm_is_vpc_routing_tables" "test1" {
		vpc =  ibm_is_vpc.testacc_vpc.id
	}
Screenshot 2024-08-28 at 11 25 47 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

resource "ibm_is_vpc_routing_table" "test_route_rt" {
  vpc                           = ibm_is_vpc.testacc_vpc.id
  name                          = "test-vpc-routing-table"
  route_direct_link_ingress     = true
  route_transit_gateway_ingress = false
  route_vpc_zone_ingress        = false
}
Screenshot 2024-08-28 at 11 27 48 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

data "ibm_is_vpc_routing_table" "ibm_is_vpc_routing_table_name" {
  vpc  = ibm_is_vpc.testacc_vpc.id
  name = ibm_is_vpc_routing_table.test_route_rt.name
}
Screenshot 2024-08-28 at 11 29 25 PM

@SunithaGudisagarIBM1
Copy link
Collaborator Author

@astha-jain updated with resource group attribute where ever it is applicable, please review

Copy link
Collaborator

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to upstream

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the UI-37487-Routing-Table-CRN branch from 290a0b1 to 046ac2b Compare October 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants