Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(egw): endpoint gateway access pending #388

Closed
wants to merge 5 commits into from
Closed

Conversation

deepaksibm
Copy link
Collaborator

@deepaksibm deepaksibm commented Oct 22, 2024

Fix description. When the EGW is created for a PPSG and the PPSG has the access policy of "review", then the EGW create should not taint on timeout, as 'pending' is a valid state for EGW when PPSG is in review mode. User can either perform a permit or deny action at a later point in time as well which will make the EGW to either go to stable or failed state depending on the action

@deepaksibm
Copy link
Collaborator Author

$ tfpt TestAccIBMISVirtualEndpointGateway_Basic
=== RUN   TestAccIBMISVirtualEndpointGateway_Basic
--- PASS: TestAccIBMISVirtualEndpointGateway_Basic (127.32s)
=== RUN   TestAccIBMISVirtualEndpointGateway_Basic_SecurityGroups
--- PASS: TestAccIBMISVirtualEndpointGateway_Basic_SecurityGroups (127.51s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     258.040s


$ tfpt TestAccIBMISVirtualEndpointGateway_PPSG_With_AccessPolicy_Review_And_Timeout
=== RUN   TestAccIBMISVirtualEndpointGateway_PPSG_With_AccessPolicy_Review_And_Timeout
--- PASS: TestAccIBMISVirtualEndpointGateway_PPSG_With_AccessPolicy_Review_And_Timeout (1997.14s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     2000.278s

@deepaksibm deepaksibm requested a review from ujjwal-ibm October 29, 2024 10:46
@deepaksibm
Copy link
Collaborator Author

Upstream PR merged

@deepaksibm deepaksibm closed this Dec 16, 2024
@deepaksibm deepaksibm deleted the egwfix branch December 16, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants