Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-37534 Block: Dynamic bandwidth allocation development #392

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SunithaGudisagarIBM1
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 changed the title Volume qos mode UI-37534 Block: Dynamic bandwidth allocation development Nov 4, 2024
@ujjwal-ibm ujjwal-ibm self-requested a review November 5, 2024 06:37
@@ -737,6 +737,7 @@ Review the argument references that you can specify for your resource.
- `user_data` - (Optional, String) User data to transfer to the instance. For more information, about `user_data`, see [about user data](https://cloud.ibm.com/docs/vpc?topic=vpc-user-data).
- `volumes` (Optional, List) A comma separated list of volume IDs to attach to the instance.
- `vpc` - (Required, Forces new resource, String) The ID of the VPC where you want to create the instance. When using `instance_template`, `vpc` is not required.
- `volume_bandwidth_qos_mode` - (Optional, String) The volume bandwidth QoS mode to use for this virtual server instance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be before vpc ?

@@ -214,6 +214,14 @@ func ResourceIBMISInstanceTemplate() *schema.Resource {
Description: "The amount of bandwidth (in megabits per second) allocated exclusively to instance storage volumes",
},

isInstanceVolumeBandwidthQoSMode: {
Type: schema.TypeString,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not computed ?

@ujjwal-ibm ujjwal-ibm self-requested a review November 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants