-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js Version 9.X and 10.X support. #398
Conversation
Thank you! |
Hello.. When will this PR be merged? |
@alobaidizt We are testing the changes on different platforms to avoid any regression. We'll merge the code soon. Thanks. |
@rhtpandeyIN Currently, I got below result for test files on Mac with node.js 10.1.0. Mostly floating exception. We need to check it. Stdout: Stderr: Running test 3 for [DB2] : test-bad-pool-connection-issue-42 ... fail Caught Signal SIGFPE Stdout: Stderr: Running test 4 for [DB2] : test-basic-test ... success Stdout: Stderr: Running test 12 for [DB2] : test-call-async ... success Stdout: Stderr: Running test 15 for [DB2] : test-connection-object ... fail Caught Signal SIGFPE Stdout: Stderr: Running test 16 for [DB2] : test-date ... fail Caught Signal SIGFPE Stdout: Stderr: Running test 17 for [DB2] : test-describe-column ... success Stdout: Stderr: Running test 25 for [DB2] : test-instantiate-one-and-end ... success Stdout: Stderr: Running test 27 for [DB2] : test-issue-get-column-value-2 ... success Stdout: Stderr: Running test 31 for [DB2] : test-memory-leaks-new-objects ... success Stdout: Stderr: Running test 38 for [DB2] : test-pool-close ... fail Caught Signal SIGFPE Stdout: Stderr: Running test 39 for [DB2] : test-pool-connect ... success Stdout: Stderr: Running test 44 for [DB2] : test-prepareSync-multiple-execution ... success Stdout: Stderr: Running test 49 for [DB2] : test-query-insert ... success Stdout: Stderr: Running test 53 for [DB2] : test-queryStream ... fail Caught Signal SIGFPE Stdout: Stderr: Running test 54 for [DB2] : test-querySync-select-with-exception ... fail Caught Signal SIGFPE Stdout: Stderr: Running test 55 for [DB2] : test-querySync-select ... success Results : 16 of 60 tests failed. Total execution time = 6 min 2 sec. |
Thank you @bimakjha for your update! :) |
Do y'all need help testing this on AIX? If you point me to directions / instructions can help you with that. |
@ukulanne Yes, please follow below steps: |
I was swamped into another project and have not had chance to test this until now: [panda test]$ node run-tests.js Warning : there are 23 disabled tests Running test 1 for [DB2] : test-all-data-types ... fail Caught Signal SIGILL Stdout: Stderr: Running test 2 for [DB2] : test-bad-connection-string ... success Stdout:After first iteration and before start of second iteration,
|
Thanks @ukulanne for testing it on AIX. Could you please check why |
@bimaljha [panda test]$ node test-all-data-types.js I also get the core dump with a simple test aplication: [panda aix-server-example]$ ls Running this same sample app runs fine on linux x86 The core dump seems to happen right after connecting to the db. Unfortunately right now the gdb rpm available at https://www.ibm.com/developerworks/aix/library/aix-toolbox/alpha.html#G conflicts with the binutils rpm. |
[panda aix-server-example]$ gdb node core Type "apropos word" to search for commands related to "word"... warning: core file may not match specified executable file. |
Please add support for node v10 =) |
@bimalkjha @rhtpandeyIN Is there anything else I can do to try debug this problem so it can work on AIX. Any pointers would be helpful. Thanks. |
Nan 2.11.0 released Aug 25 with Node 10 support. Does that mean you can merge this branch now and cut a new ibm_db release? thanks!! |
I am finding the same problems reported on #439 with Nan 2.11 |
* Update README.md (Bimal Kumar Jha) * Adding windows binary support for Node V9.X, V10.X, V11.X (#492) (Rohit Pandey) * Fix STEPLIB typos for SDSNLOD2 library (#488) (Joran Siu) * Revert "Fix ApiDocumentation.md to use Github Markdown anchors" (#491) (Bimal Kumar Jha) * Remove extraneous comma in zos test config (#479) (Joran Siu) * Node.js Version 9.X and 10.X support. (#398) (Rohit Pandey) * Change links to add user-content- prefix, trim whitespace (#477) (Michael Varrieur) * fix test case (Bimal Jha)
Resolved issue #396, #387