add rhel10 support

[andrewschoen]

this also disables tests

[phlogistonjohn]

It's fine for now, but I don't see it serving as a long term thing. But for longer term stuff we should probably start off fixing things in upstream. If this is not going to conflict with upstream I'm happy to approve, just want to give you a chance to react before I do so.

[anoopcs9]

this also disables tests

With python3-inotify_simple available for el10 I think we can still go with the tests.

[andrewschoen]

this also disables tests

With python3-inotify_simple available for el10 I think we can still go with the tests.

I try another build with tests enabled.

[andrewschoen]

It's fine for now, but I don't see it serving as a long term thing. But for longer term stuff we should probably start off fixing things in upstream. If this is not going to conflict with upstream I'm happy to approve, just want to give you a chance to react before I do so.

I agree with taking this upstream. In this case I don't think that python3-inotify_simple is available upstream for el10 quite yet.

[andrewschoen]

It's fine for now, but I don't see it serving as a long term thing. But for longer term stuff we should probably start off fixing things in upstream. If this is not going to conflict with upstream I'm happy to approve, just want to give you a chance to react before I do so.

I agree with taking this upstream. In this case I don't think that python3-inotify_simple is available upstream for el10 quite yet.

I guess there is condition already for adding to the package list for rhel. I can add python3-inotify_simple here https://github.com/ibmstorage/sambacc/pull/2/files#diff-c40fccdb1cf0d825bb7cc26a7825b28952067a0587d64bdbc7a8e28774b65789R141

[andrewschoen]

this also disables tests

With python3-inotify_simple available for el10 I think we can still go with the tests.

I try another build with tests enabled.

It built fine with the tests included, I've added them back.

[andrewschoen]

It's fine for now, but I don't see it serving as a long term thing. But for longer term stuff we should probably start off fixing things in upstream. If this is not going to conflict with upstream I'm happy to approve, just want to give you a chance to react before I do so.

I agree with taking this upstream. In this case I don't think that python3-inotify_simple is available upstream for el10 quite yet.

I guess there is condition already for adding to the package list for rhel. I can add python3-inotify_simple here https://github.com/ibmstorage/sambacc/pull/2/files#diff-c40fccdb1cf0d825bb7cc26a7825b28952067a0587d64bdbc7a8e28774b65789R141

I'm testing this now. If it works I can close this PR and open it upstream first.

[andrewschoen]

Closing in favor of samba-in-kubernetes#175