Bump pf #3
Closed
Bump pf #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring:
- Explicitly add `i18n` initialization on the root `index.tsx`.
- Move `dayjs` initialization to its own file `dayjs.ts` referenced from
`index.tsx`. This follows the `i18n` init style.
- Move PF css includes from `App.tsx` to `index.tsx`
Signed-off-by: Scott J Dickerson <[email protected]>
https://issues.redhat.com/browse/MTA-1961 Signed-off-by: ibolton336 <[email protected]>
fix typo Signed-off-by: Alejandro Brugarolas <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
Resolves [[Dependencies]Application inventory page shows no applications once Accessed from dependencies](https://issues.redhat.com/browse/MTA-2007) Resolves https://issues.redhat.com/browse/MTA-2056 - Removes the auto applied search string when direct navigating using the side nav. This was applying filters that were not registered within the application table ( & other tables). I.E when navigating from the dependencies page, the search string was including an "applications.name" filter which is just referenced as "name" within the applications table. Future iterations may allow us to rewrite the search string when navigating between pages or standardizing on a specific key for app names on the back end. - Adds the ability to parse the url string for initial search values in the dependencies toolbar. - Adds associated clear filters handler to clear the url when the toolbar clear button is pressed. This is necessary to overwrite the initial filter values. Implemented this in dependencies page & applications table. There may be a need to incorporate this into filter toolbar at some point. Signed-off-by: ibolton336 <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
…or#1666) Resolves https://issues.redhat.com/browse/MTA-1967 Addresses an issue where the assessed boolean for archetypes is set to true when all questionnaires are marked as not-required. Uses the new assessment.required boolean surfaced in konveyor/tackle2-hub@2552233 to filter out these false positives. --------- Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: David Zager <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1965 Signed-off-by: ibolton336 <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1790 <img width="1613" alt="Screenshot 2024-02-15 at 2 09 40 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/ce001d5f-24b5-49fc-b4ea-a879b4839308"> <img width="1630" alt="Screenshot 2024-02-15 at 2 09 08 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/8a46de3e-5025-4648-aab6-2dd1f6e899cb"> <img width="1618" alt="Screenshot 2024-02-15 at 2 09 01 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/a0f7c3c4-0879-465b-8e51-a0c92750bb7a"> Signed-off-by: Ian Bolton <[email protected]>
<img width="512" alt="Screenshot 2024-02-14 at 1 47 42 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/767b6c34-f097-4f08-9260-56bc28ff9c07"> Capitalized source names - previously assessment and archetype sources were lowercase which led to a confusing UX. Motivated by konveyor/tackle2-hub#603 incoming changes. Signed-off-by: Ian Bolton <[email protected]>
<img width="1240" alt="Screenshot 2024-01-04 at 12 05 39 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/4618ca64-e961-4f05-b9c6-59e392247e20"> Signed-off-by: ibolton336 <[email protected]>
Resolves: https://issues.redhat.com/browse/MTA-1468 --------- Signed-off-by: Maayan Hadasi <[email protected]>
https://issues.redhat.com/browse/MTA-1721 Signed-off-by: Ian Bolton <[email protected]>
…veyor#1669) - Resolves: - https://issues.redhat.com/browse/MTA-1872 - https://issues.redhat.com/browse/MTA-467 - Upgrade our usage of the PF select component to the pf 5 supported version. --------- Signed-off-by: ibolton336 <[email protected]> Signed-off-by: Ian Bolton <[email protected]>
…r#1690) https://issues.redhat.com/browse/MTA-2260 - Previously, the notification delay timeout was being overridden by the timeout set on the alert component itself. This fixes this accidental override. - Lengthens timeout for notification clear globally to 8 seconds. Signed-off-by: Ian Bolton <[email protected]>
https://issues.redhat.com/browse/MTA-1888 It appears that an application can only have a single review. So this changes the Tab title from `Reviews` -> `Review` and drops the redundant header inside. Signed-off-by: David Zager <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
There was a suggestion to update the drawer chips to a link since as the list of chips grows, it will not be sustainable to show all chips in drawer. The change here moves to a pre-filter for the archetypes category in the applications table which is linkable from the archetype drawer. https://issues.redhat.com/browse/MTA-2283 <img width="1677" alt="Screenshot 2024-02-21 at 4 51 48 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/f787e32b-df98-48de-92a8-91521059df69"> --------- Signed-off-by: ibolton336 <[email protected]> Signed-off-by: Ian Bolton <[email protected]>
…onveyor#1691) Resolves https://issues.redhat.com/browse/MTA-1845 After discussions with UXD ( @JustinXHale ), determined that this export functionality can safely be disabled when no apps are available to export. Apps that have already been exported already are assigned to a ticket and Jira and cannot be re-exported until they are unlinked. <img width="351" alt="Screenshot 2024-02-16 at 3 49 30 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/b432205b-98c6-42a2-8950-2132cbd41152"> Signed-off-by: Ian Bolton <[email protected]>
https://issues.redhat.com/browse/MTA-1807 Signed-off-by: Ian Bolton <[email protected]>
…r#1685) Resolves konveyor#1472 - Adds an empty state to the codeviewer when the codesnip is not populated / is an empty string or whitespace characters. <img width="1188" alt="Screenshot 2024-02-13 at 12 43 05 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/eed3cf5d-e5a4-44eb-846f-6397c50b23a9"> Signed-off-by: Ian Bolton <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-2008 && konveyor#1498 Signed-off-by: Ian Bolton <[email protected]>
…onveyor#1702) Resolves https://issues.redhat.com/browse/MTA-2004 <img width="1197" alt="Screenshot 2024-02-27 at 9 59 25 AM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/720d137a-098b-4736-ba1c-b0905073c144"> --------- Signed-off-by: Ian Bolton <[email protected]>
…r#1707) Resolves https://issues.redhat.com/browse/MTA-2320 - Missed a case when calculating associated assessed archetypes to an application. If application is passed to the useFetchArchetypes query but application.archetypes is null, still returning all archetypes instead of an empty list. --------- Signed-off-by: Ian Bolton <[email protected]>
…#1705) Resolves https://issues.redhat.com/browse/MTA-1958 - Also adds translation entry for other similar message in toolbar --------- Signed-off-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
…nveyor#1706) Resolves https://issues.redhat.com/browse/MTA-1880 - Adds spacing for vertical tabs to align with question table - Adds spacing for expanded section to meet PF standards as outlined in above issue comments from UXD - Adds Explanation term for explanation previously not labeled. <img width="1638" alt="Screenshot 2024-02-27 at 2 48 46 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/a5d915d9-7977-48cd-ac4c-5c3ca1cdc909"> --------- Signed-off-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-2296 Resolves https://issues.redhat.com/browse/MTA-1973 --------- Signed-off-by: Ian Bolton <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-2322 - Need to load the select options into the dropdown state in cases where category.selectOptions is async --------- Signed-off-by: Ian Bolton <[email protected]>
…r#1711) Resolves https://issues.redhat.com/browse/MTA-2093 - Uses the assessment risk when a specific questionnaire is selected in the landscape filter rather than the application risk. --------- Signed-off-by: Ian Bolton <[email protected]>
…yor#1724) - Reduce assessment fetch calls resulting from unnecessary hook calls & query invalidations. - Passes assessments down from app table into sub components Signed-off-by: Ian Bolton <[email protected]>
…eyor#1727) - Replaces erroneous not available status that is shown when no assessments are available on an app Signed-off-by: Ian Bolton <[email protected]>
Addresses part of https://issues.redhat.com/browse/MTA-2359 Signed-off-by: Ian Bolton <[email protected]>
…1733) [App 'Assessment' status shows Completed and Inheritance indicator icon even when not associated with archetypes](https://issues.redhat.com/browse/MTA-2354) Signed-off-by: Ian Bolton <[email protected]>
## Summary Refactor and enhance branding capabilities. Now branding is included from a single directory that contains at least `strings.json`, `manifest.json`, and `favicon.ico`. Any other assets may be placed in the directory and will be copied to the bundled app. Running the build as normal should show no difference. Running the build with `BRANDING=./some-other-brand npm run start:dev` will try to use a branding from the specified directory (that is relative to the project's source root). See `BRANDING.md` for more details. Resolves: konveyor#1682 ## Details Branding changes: - Move Konveyor branding assets to a project top-level branding directory - Remove MTA branding assets - Remove profile/branding constants from `env` and client module - Embed branding strings and assets in the common module - `strings.json` is templated to allow the build to adjust asset URL path roots as necessary - `brandingAssetPath()` - server's index.html generation sources the template strings from the common module's branding strings - `HeaderApp` and `AppAboutModal` components support branding by using the `useBranding` hook - `BRANDING` as a relative path is computed from the project root - webpack build source branding assets directly from the common module - Unit tests, snapshots and jest configs updated as necessary Jest changes: - Use `react-i18next` mock from `client/__mocks__` as a more robust mock borrowed from react-i18n repos - Move `setupTests.ts` into `client/src/app/test-config` to keep jest test config code all in the same directory Related changes: - Upgrade rollup to v4, add new rollup plugins (copy, virtual) --------- Signed-off-by: Scott J Dickerson <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
On merge to main, konveyor#1664 showed that the normal rollup package does not support the linux-ppc64 platform. This was not caught earlier as building on github actions always worked with the standard `rollup` package. The error message displayed on the multiarch build attempt is: > Error: Your current platform "linux" and architecture "ppc64" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead. Swapping the package `rollup` to `@rollup/wasm-node` should enable the ppc64 build. Signed-off-by: Scott J Dickerson <[email protected]>
https://issues.redhat.com/browse/MTA-2359 - Removes query invalidation & additional archetypes / reviews api calls inside each instance of a rendered (but hidden) drawer. This was causing a huge performance hit. - Adds margin at top of reviews tab <img width="540" alt="Screenshot 2024-03-04 at 2 46 40 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/9c6c8a8f-f8c6-45c9-8609-86a30e206a99"> Signed-off-by: Ian Bolton <[email protected]>
Following up on PRs konveyor#1664 and konveyor#1739, downgrade to `rollup@^3.0`. The v4 of rollup has "native" code that runs the build, and that code does not currently work with s390 builds [1]. Since konveyor is built for x86, arm, ppc, and s390, all of those need to work. When the s390 builds can work with the wasm bits, we can upgrade to `rollup@^4.0` again. [1] - rollup/rollup#5354 Signed-off-by: Scott J Dickerson <[email protected]>
Reference-Url: https://issues.redhat.com/browse/MTA-2003 ### Before  ### After  Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Builds keep failing with EMFILE errors, so follow the advice from a similar issue work around: npm/cli#4783 (comment) --------- Signed-off-by: Scott Dickerson <[email protected]>
Resolves: konveyor#1744 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Changes:
1. fix dead links i.e. to PF4 components or refactored code
2. in README
1. OLM addon issue
2. be more general about minikube drivers i.e. rootless or without VMs
3. prefer port forwarding to proxy when accessing dashboard (seems
safer)
3. in INTERNATIONALIZATION - comment that questionnaire is data imported
from YAML files
---------
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Refactor the `ReviewFields` component in advance of konveyor#1745: - The component is used on the Review tab of application and archetype details drawer - The input prop `reviews` was not used in any current containing component. Push the `useFetchReviews()` hook down to the component itself. This keeps the data fetch as close as possible to where it is used. - Move the component to `@app/components/detail-drawer` folder since it is used in more than one page grouping Signed-off-by: Scott J Dickerson <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
Resolves: https://issues.redhat.com/browse/MTA-1970 Signed-off-by: Maayan Hadasi <[email protected]> Co-authored-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
<!-- ## PR Title Prefix Every **PR Title** should be prefixed with :text: to indicate its type. - Breaking change:⚠️ (`⚠️ `) - Non-breaking feature: ✨ (`✨`) - Patch fix: 🐛 (`🐛`) - Docs: 📖 (`📖`) - Infra/Tests/Other: 🌱 (`🌱`) - No release note: 👻 (`👻`) For example, a pull request containing breaking changes might look like `⚠️ My pull request contains breaking changes`. Since GitHub supports emoji aliases (ie. `👻`), there is no need to include the emoji directly in the PR title -- **please use the alias**. It used to be the case that projects using emojis for PR typing had to include the emoji directly because GitHub didn't render the alias. Given that `⚠️ ` is easy enough to read as text, easy to parse in release tooling, and rendered in GitHub well, we prefer to standardize on the alias. For more information, please see the Konveyor [Versioning Doc](https://github.com/konveyor/release-tools/blob/main/VERSIONING.md). --> Signed-off-by: David Zager <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
Resolves: konveyor#1773 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves: konveyor#1754 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
Review states: 1. Completed - a review exists 2. NotStarted Assessment states: 1. Completed - all required assessments done (based on 'assessed' flag) 2. InProgress - some assessments done 3. NotStarted Resolves: konveyor#1751 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
Refactoring:
- Split CI, one for repo tests and one for global tests
- Only enable global CI on main (with a note)
- Global CI configured like the multiarch build to cancel in progress
runs if a new run starts
- Repo CI bump the version of action `codecov/codecov-action` based on
runtime warnings
- Add `--ignoreScripts` to the `npm clean-install` in the Dockerfile to
avoid running unnecessary postinstall scripts with the build running
directly after the install.
Signed-off-by: Scott J Dickerson <[email protected]>
Resolves: https://issues.redhat.com/browse/MTA-1578 Signed-off-by: Maayan Hadasi <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
Update to the 5.2 release of the patternfly libraries. See release notes https://www.patternfly.org/get-started/release-highlights/#patternfly-5.2 Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Bumped: @patternfly/react-code-editor @patternfly/react-core @patternfly/react-table Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test CI