Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lunar lander dependency issues #367

Merged
merged 48 commits into from
Sep 10, 2023
Merged

Fix lunar lander dependency issues #367

merged 48 commits into from
Sep 10, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Sep 10, 2023

Description

We have been running into some issues with lunar lander not running properly on Colab due to dependency issues. We also had some dependency issues with swig (see #366).

Regarding swig, I found that it was difficult to get the examples to work properly with swig because we were not using a virtual environment, so the different Python versions were being confused -- hence we would get errors like "Module not found" when trying to use swig. To remedy this problem, I have started #367 to run all PR jobs in a Conda env. This PR uses a Conda env only for the examples job.

TODO

  • Upgrade to gymnasium 0.29.1 due to Jax-jumpy issues -> gymnasium 0.27.0 depended on jax-jumpy, which resulted in installation errors because jax-jumpy was not fully production-ready
  • Fix ordering of Dask imports
  • Re-run tutorial on Colab to get times; update tutorial times accordingly
  • Run on Colab and fix deprecation warnings -> looks like there were no warnings
  • Try running locally in Python 3.10 -> Colab CPU seems really slow compared to local CPU, but this makes sense
  • Fix deps in lunar lander example
  • Make example.sh script run multiple pip install commands

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit 8a5be85 into master Sep 10, 2023
@btjanaka btjanaka deleted the lander-deps branch September 10, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant