-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lunar lander dependency issues #367
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit baace00.
362151c
to
80772bf
Compare
This reverts commit 80772bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been running into some issues with lunar lander not running properly on Colab due to dependency issues. We also had some dependency issues with swig (see #366).
Regarding swig, I found that it was difficult to get the examples to work properly with swig because we were not using a virtual environment, so the different Python versions were being confused -- hence we would get errors like "Module not found" when trying to use swig. To remedy this problem, I have started #367 to run all PR jobs in a Conda env. This PR uses a Conda env only for the examples job.
TODO
Questions
Status
CONTRIBUTING.md
yapf
pytest
pylint
HISTORY.md