Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random stats based on starting level #113

Merged
merged 16 commits into from
Jan 19, 2025
Merged

Random stats based on starting level #113

merged 16 commits into from
Jan 19, 2025

Conversation

Phantom5800
Copy link
Contributor

If StartingLevel is provided and is a valid level from 0-27, randomly distribute stats.

@icebound777
Copy link
Owner

At the point where the OptionsSet is being built the seeding for randomization is not initialized yet.
That happens in random_seed.py, and only afterwards the randint function can be used deterministically for us.
Since the random starting stats do not influence the logic currently, I recommend calling that code somewhere after the Generation attempt loop in random_seed.py. Preferably outsourced into its own file within the rando_modules directory.

@Phantom5800 Phantom5800 changed the title Random stats based on starting level Random stats based on starting level and manually setting chapter scales Nov 15, 2024
@Phantom5800 Phantom5800 marked this pull request as ready for review November 15, 2024 21:53
@Phantom5800
Copy link
Contributor Author

Marking as ready for review after verifying changes myself across a handful of seeds.

@Phantom5800 Phantom5800 force-pushed the random_stats branch 2 times, most recently from 95e09e5 to 14d5d7f Compare November 21, 2024 21:08
@Phantom5800 Phantom5800 changed the title Random stats based on starting level and manually setting chapter scales Random stats based on starting level Jan 14, 2025
icebound777
icebound777 requested changes Jan 16, 2025
View reviewed changes
Copy link
Owner

@icebound777 icebound777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: a few small things

icebound777
icebound777 reviewed Jan 17, 2025
View reviewed changes
Copy link
Owner

@icebound777 icebound777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Copy & Paste error in settings files, after that lgtm

@icebound777 icebound777 merged commit fe5cc21 into icebound777:dev Jan 19, 2025
@Phantom5800 Phantom5800 deleted the random_stats branch February 26, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebound777 icebound777 icebound777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phantom5800 @icebound777