Skip to content

Commit

Permalink
Merge pull request #2090 from nyurik/mapping
Browse files Browse the repository at this point in the history
Chore: Apply clippy map transformations
  • Loading branch information
hecrj authored Sep 19, 2023
2 parents a4dbf07 + c997aad commit 582da10
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 15 deletions.
4 changes: 1 addition & 3 deletions core/src/mouse/click.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ impl Click {
};

self.position == new_position
&& duration
.map(|duration| duration.as_millis() <= 300)
.unwrap_or(false)
&& duration.is_some_and(|duration| duration.as_millis() <= 300)
}
}
6 changes: 4 additions & 2 deletions examples/integration/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,10 @@ pub fn main() -> Result<(), Box<dyn std::error::Error>> {
viewport.scale_factor(),
)
})
.map(mouse::Cursor::Available)
.unwrap_or(mouse::Cursor::Unavailable),
.map_or(
mouse::Cursor::Unavailable,
mouse::Cursor::Available,
),
&mut renderer,
&Theme::Dark,
&renderer::Style {
Expand Down
5 changes: 1 addition & 4 deletions examples/screenshot/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,7 @@ fn numeric_input(
) -> Element<'_, Option<u32>> {
text_input(
placeholder,
&value
.as_ref()
.map(ToString::to_string)
.unwrap_or_else(String::new),
&value.as_ref().map_or_else(String::new, ToString::to_string),
)
.on_input(move |text| {
if text.is_empty() {
Expand Down
2 changes: 1 addition & 1 deletion wgpu/src/image/vector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ impl Cache {
.ok()
});

tree.map(Svg::Loaded).unwrap_or(Svg::NotFound)
tree.map_or(Svg::NotFound, Svg::Loaded)
}
svg::Data::Bytes(bytes) => {
match usvg::Tree::from_data(bytes, &usvg::Options::default()) {
Expand Down
2 changes: 1 addition & 1 deletion wgpu/src/triangle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ fn multisample_state(
antialiasing: Option<Antialiasing>,
) -> wgpu::MultisampleState {
wgpu::MultisampleState {
count: antialiasing.map(|a| a.sample_count()).unwrap_or(1),
count: antialiasing.map_or(1, Antialiasing::sample_count),
mask: !0,
alpha_to_coverage_enabled: false,
}
Expand Down
3 changes: 1 addition & 2 deletions winit/src/application/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ where
self.viewport.scale_factor(),
)
})
.map(mouse::Cursor::Available)
.unwrap_or(mouse::Cursor::Unavailable)
.map_or(mouse::Cursor::Unavailable, mouse::Cursor::Available)
}

/// Returns the current keyboard modifiers of the [`State`].
Expand Down
3 changes: 1 addition & 2 deletions winit/src/clipboard.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ impl Clipboard {
pub fn connect(window: &winit::window::Window) -> Clipboard {
let state = window_clipboard::Clipboard::connect(window)
.ok()
.map(State::Connected)
.unwrap_or(State::Unavailable);
.map_or(State::Unavailable, State::Connected);

Clipboard { state }
}
Expand Down

0 comments on commit 582da10

Please sign in to comment.