Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar disabled style status to allow custom styles for always visible, but not overflowing scrollbars. #2585

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

dtzxporter
Copy link
Contributor

Feel free to change the 'name' of it. I originally used 'disabled' to signal that it's not usable, but still visible. 'Overflowing' may be a better term.

@dtzxporter dtzxporter force-pushed the scrollbar-show-always-disabled branch from 2f8fb69 to db2a4dc Compare September 19, 2024 19:02
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this disabled state necessary? Isn't it already obvious for a user that a scrollbar without a scroller isn't interactable?

@hecrj hecrj added this to the 0.14 milestone Sep 24, 2024
@hecrj hecrj added feature New feature or request widget addition labels Sep 24, 2024
@dtzxporter
Copy link
Contributor Author

In my app, I have a custom style that more clearly signifies that scrolling isn't available (vs scrolling being not a thing period) It's nice to be able to customize based on whether or not it's usable.

Feel free to change the 'name' of it. I originally used 'disabled' to signal that it's not usable, but still visible. 'Overflowing' may be a better term.
@hecrj hecrj force-pushed the scrollbar-show-always-disabled branch from db2a4dc to 8d9fe61 Compare January 6, 2025 19:20
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Thanks! 🙇

@hecrj hecrj enabled auto-merge January 6, 2025 19:26
@hecrj hecrj merged commit 2b4f428 into iced-rs:master Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition feature New feature or request widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants